Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: base/file_util_unittest.cc

Issue 136693004: Make all the files mapped in when running base_unittests read only. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add new unit test CopyFileACL Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_unittests.isolate ('k') | base/file_util_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 96e144de3da92944a7c3e1c9b18f2cb4bb344491..fc62064b017b65c7dcb3759e4cd4b9ea2b88a4fe 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -1398,6 +1398,60 @@ TEST_F(FileUtilTest, CopyFile) {
EXPECT_TRUE(PathExists(dest_file2));
}
+#if defined(OS_WIN) || defined(OS_POSIX)
+TEST_F(FileUtilTest, CopyFileACL) {
+ // While FileUtilTest.CopyFile asserts the content is correctly copied over,
+ // this test case asserts the access control bits are meeting expectations in
+ // CopyFileUnsafe().
+ FilePath src = temp_dir_.path().Append(FILE_PATH_LITERAL("src.txt"));
+ const std::wstring file_contents(L"Gooooooooooooooooooooogle");
+ CreateTextFile(src, file_contents);
+
+ // Set the source file to read-only.
+#if defined(OS_WIN)
+ // On Windows, it involves setting a bit.
+ DWORD attrs = GetFileAttributes(src.value().c_str());
+ ASSERT_NE(INVALID_FILE_ATTRIBUTES, attrs);
+ ASSERT_TRUE(SetFileAttributes(
+ src.value().c_str(), attrs | FILE_ATTRIBUTE_READONLY));
+ attrs = GetFileAttributes(src.value().c_str());
+ // Files in the temporary directory should not be indexed ever. If this
+ // assumption change, fix this unit test accordingly.
+ DWORD expected = (FILE_ATTRIBUTE_NOT_CONTENT_INDEXED |
+ FILE_ATTRIBUTE_ARCHIVE | FILE_ATTRIBUTE_READONLY);
+ ASSERT_EQ(expected, attrs);
+#else
+ // On all other platforms, it involves removing the write bit.
+ EXPECT_TRUE(SetPosixFilePermissions(src, 0400));
+#endif
+
+ // Copy the file.
+ FilePath dst = temp_dir_.path().Append(FILE_PATH_LITERAL("dst.txt"));
+ ASSERT_TRUE(CopyFile(src, dst));
+ EXPECT_EQ(file_contents, ReadTextFile(dst));
+
+#if defined(OS_WIN)
+ // While the source file had RO bit set, the copied file doesn't. Other file
+ // modes are copied.
+ attrs = GetFileAttributes(src.value().c_str());
+ ASSERT_EQ(expected, attrs);
+ expected = FILE_ATTRIBUTE_NOT_CONTENT_INDEXED | FILE_ATTRIBUTE_ARCHIVE;
+ attrs = GetFileAttributes(dst.value().c_str());
+ ASSERT_EQ(expected, attrs);
+#elif defined(OS_MACOSX)
+ // On OSX, file mode is copied.
M-A Ruel 2014/01/14 14:59:39 Note that I am not changing this behavior, only do
+ int mode = 0;
+ EXPECT_TRUE(GetPosixFilePermissions(dst, &mode));
+ EXPECT_EQ(0400, mode & 0600);
+#else
+ // On other POSIX, file mode is not copied.
+ int mode = 0;
+ EXPECT_TRUE(GetPosixFilePermissions(dst, &mode));
+ EXPECT_EQ(0600, mode & 0600);
+#endif
+}
+#endif // defined(OS_WIN) || defined(OS_POSIX)
+
// file_util winds up using autoreleased objects on the Mac, so this needs
// to be a PlatformTest.
typedef PlatformTest ReadOnlyFileUtilTest;
« no previous file with comments | « base/base_unittests.isolate ('k') | base/file_util_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698