Refactoring ContentVideoViewContextDelegate.java

content/browser/android/content_view_core_impl.h

Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 72a7256e6392926b193fc73f311725e0523716e4..c2298581cfe241bed5f624736fa15b3761d522c5 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -271,6 +271,12 @@ class ContentViewCoreImpl : public ContentViewCore,
 
   void RequestExternalVideoSurface(int player_id);
 
+  base::android::ScopedJavaLocalRef<jobject> GetContentVideoViewClient();
+
+  // Returns the Activity context associated with ContentViewCore.
+  // Note: This context is different with base::android::GetApplicationContext().
+  base::android::ScopedJavaLocalRef<jobject> GetContext();

[joth, 2013/04/12 17:56:24]

This is misleading, as CVC can be used without an activity, so having this
getter could lead to mistakes.
(for fullscreen video, we accept that it's just going to fail if the webview is
used with a non-activity context, but I'm worried the getter here will cause new
code to make incorrect assumptions here)

With getContext on ContentVideoView pushed the policy of how to deal this up to
the embedder, and was clear that we are asking for a context specifically for
hosting the fullscreen video, whereas here it's ambiguous what this is good for.
Maybe it's OK just to comment this is the context that the CVC was created with,
which would typically be an Activity context for an onscreen view.

[michaelbai, 2013/04/18 18:21:59]

Done.

+
   // --------------------------------------------------------------------------
   // Methods called from native code
   // --------------------------------------------------------------------------