Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1366893002: Make window.scroll properties relative to the layout viewport. (Closed)

Created:
5 years, 2 months ago by ymalik
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make window.scroll properties relative to the layout viewport. window.scroll properties being relative to visual viewport breaks some pages under pinch-zoom. The original plan was to have all APIs reflect the layout viewport (and introduce new APIs for visual). This CL is an initial step towards that and the window.scroll properties will be relative to the layout viewport if the 'inert-visual-viewport' flag is set. BUG=489206 Committed: https://crrev.com/9b92c13df0e3c771a89a5beb6ea892704fd2ed05 Cr-Commit-Position: refs/heads/master@{#351104}

Patch Set 1 #

Patch Set 2 : Added chrome-side changes to enable inert visual viewport #

Total comments: 2

Patch Set 3 : "worked on review comments" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/web_preferences.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/scroll-behavior/main-frame-pinch-scrolls-layout-viewport.html View 1 chunk +83 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/scroll-behavior/main-frame-pinch-scrolls-layout-viewport-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 8 chunks +23 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (9 generated)
ymalik
Just applied the patch after the blink repo merge. Will need another LGTM :)
5 years, 2 months ago (2015-09-24 14:43:50 UTC) #2
bokan
lgtm
5 years, 2 months ago (2015-09-24 14:44:35 UTC) #3
Rick Byers
RS lgtm, but please add a link to the original codereview (here in review comments ...
5 years, 2 months ago (2015-09-24 14:55:19 UTC) #4
ymalik
On 2015/09/24 14:55:19, Rick Byers wrote: > RS lgtm, but please add a link to ...
5 years, 2 months ago (2015-09-24 14:59:13 UTC) #5
ymalik
@bokan PTAL, I added the chromium side changes to this CL.
5 years, 2 months ago (2015-09-24 19:59:42 UTC) #6
bokan
still lgtm (you'll need new OWNERs for the Chromium side changes though)
5 years, 2 months ago (2015-09-25 01:42:27 UTC) #7
ymalik
+kenrb@ for common_param_traits_macros +avi@ for content/public and content/renderer content/browser
5 years, 2 months ago (2015-09-25 14:20:24 UTC) #9
ymalik
+isherman@ for histograms.xml
5 years, 2 months ago (2015-09-25 14:22:25 UTC) #11
Avi (use Gerrit)
:/ https://codereview.chromium.org/1366893002/diff/20001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/1366893002/diff/20001/content/browser/renderer_host/render_process_host_impl.cc#newcode1335 content/browser/renderer_host/render_process_host_impl.cc:1335: switches::kInertVisualViewport, If the switches in a list are ...
5 years, 2 months ago (2015-09-25 14:28:42 UTC) #12
ymalik
https://codereview.chromium.org/1366893002/diff/20001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/1366893002/diff/20001/content/browser/renderer_host/render_process_host_impl.cc#newcode1335 content/browser/renderer_host/render_process_host_impl.cc:1335: switches::kInertVisualViewport, On 2015/09/25 14:28:41, Avi wrote: > If the ...
5 years, 2 months ago (2015-09-25 14:36:41 UTC) #13
kenrb
ipc lgtm
5 years, 2 months ago (2015-09-25 14:56:39 UTC) #14
Avi (use Gerrit)
lgtm
5 years, 2 months ago (2015-09-25 17:00:13 UTC) #15
Ilya Sherman
histograms.xml lgtm
5 years, 2 months ago (2015-09-26 00:19:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366893002/40001
5 years, 2 months ago (2015-09-27 19:44:04 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/118726)
5 years, 2 months ago (2015-09-27 19:59:57 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366893002/40001
5 years, 2 months ago (2015-09-28 13:56:14 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/119211)
5 years, 2 months ago (2015-09-28 14:16:38 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366893002/40001
5 years, 2 months ago (2015-09-28 16:44:53 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 19:23:28 UTC) #28
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:26:39 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9b92c13df0e3c771a89a5beb6ea892704fd2ed05
Cr-Commit-Position: refs/heads/master@{#351104}

Powered by Google App Engine
This is Rietveld 408576698