third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp - Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix UAF in BackgroundHTMLParser Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/FrameLoader.cpp ('K') | « third_party/WebKit/Source/platform/TimerTest.cpp ('k') | third_party/WebKit/Source/web/AssociatedURLLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

index 8cf1c0484cf020e54e02e18caf429155c9986b45..abc94b7fe45d54dacbf5343d12c961e929cb98d1 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurfaceTest.cpp

@@ -260,7 +260,7 @@ private:

MockWebTaskRunner() : m_task(0) { }

~MockWebTaskRunner() override { }

- virtual void postTask(const WebTraceLocation&, Task* task)

+ void postTask(const WebTraceLocation&, Task* task) override

{

EXPECT_EQ((Task*)0, m_task);

m_task = task;

@@ -268,6 +268,12 @@ private:

void postDelayedTask(const WebTraceLocation&, Task*, double delayMs) override { ASSERT_NOT_REACHED(); };

+ WebTaskRunner* clone() override

+ {

+ ASSERT_NOT_REACHED();

+ return nullptr;

+ }

Task* m_task;

};