Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix UAF in BackgroundHTMLParser Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp b/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
index 6db3012492d6c6c1ed3e4c5df48d9edb7500059b..18683001e3bf3f5fd67bf6d60f0ff6aafe947c02 100644
--- a/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
+++ b/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
@@ -72,7 +72,7 @@ public:
explicit MockWebTaskRunner(Deque<OwnPtr<WebTaskRunner::Task>>* tasks) : m_tasks(tasks) { }
~MockWebTaskRunner() override { }
- virtual void postTask(const WebTraceLocation&, Task* task)
+ void postTask(const WebTraceLocation&, Task* task) override
{
m_tasks->append(adoptPtr(task));
}
@@ -82,6 +82,12 @@ public:
ASSERT_NOT_REACHED();
}
+ WebTaskRunner* clone() override
+ {
+ ASSERT_NOT_REACHED();
+ return nullptr;
+ }
+
Deque<OwnPtr<WebTaskRunner::Task>>* m_tasks; // NOT OWNED
};

Powered by Google App Engine
This is Rietveld 408576698