third_party/WebKit/public/platform/WebTaskRunner.h - Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebTaskRunner.h

Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a clone method to WebTaskRunner which lets us solve the lifetime issue. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/public/platform/WebURLLoader.h » ('j') | third_party/WebKit/public/platform/WebURLLoader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebTaskRunner.h

diff --git a/third_party/WebKit/public/platform/WebTaskRunner.h b/third_party/WebKit/public/platform/WebTaskRunner.h

index b3e9745fed227a7ff3dc4f9900b96bb97c47f51b..c5afabfd3b9654445fa85787257435f4fd95dc11 100644

--- a/third_party/WebKit/public/platform/WebTaskRunner.h

+++ b/third_party/WebKit/public/platform/WebTaskRunner.h

@@ -39,6 +39,9 @@ public:

// Takes ownership of |Task|. Can be called from any thread.

virtual void postDelayedTask(const WebTraceLocation&, Task*, double delayMs) {}

+ // Returns a clone of the WebTaskRunner.

+ virtual WebTaskRunner* clone() { return nullptr; }

Sami 2015/09/29 11:22:47 nit: I think these can be pure virtual now that we

alex clarke (OOO till 29th) 2015/09/29 16:10:36 Done.

#ifdef INSIDE_BLINK

// Helpers for posting bound functions as tasks.

typedef Function<void()> ClosureTask;