content/renderer/render_thread_impl.cc - Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a clone method to WebTaskRunner which lets us solve the lifetime issue. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/web_url_loader_impl.cc ('K') | « content/renderer/render_thread_impl.h ('k') | content/renderer/renderer_blink_platform_impl.h » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_thread_impl.cc

diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc

index 9266eeb1c96423967c34c7ddfb3aaafaf3927240..dc02175bccddeb4fa0c1d4e16815257909090503 100644

--- a/content/renderer/render_thread_impl.cc

+++ b/content/renderer/render_thread_impl.cc

@@ -1040,9 +1040,10 @@ void RenderThreadImpl::SetResourceDispatchTaskQueue(

const scoped_refptr<base::SingleThreadTaskRunner>& resource_task_queue) {

// Add a filter that forces resource messages to be dispatched via a

// particular task runner.

- resource_scheduling_filter_ =

+ ResourceSchedulingFilter* filter =

Sami 2015/09/29 11:22:47 scoped_ptr?

alex clarke (OOO till 29th) 2015/09/29 16:37:38 Done.

new ResourceSchedulingFilter(resource_task_queue, resource_dispatcher());

- channel()->AddFilter(resource_scheduling_filter_.get());

+ channel()->AddFilter(filter);

+ resource_dispatcher()->SetResourceSchedulingFilter(filter);

// The ChildResourceMessageFilter and the ResourceDispatcher need to use the

// same queue to ensure tasks are executed in the expected order.