content/child/web_url_loader_impl.h - Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_url_loader_impl.h

Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a clone method to WebTaskRunner which lets us solve the lifetime issue. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/resource_scheduling_filter.cc ('K') | « content/child/resource_scheduling_filter.cc ('k') | content/child/web_url_loader_impl.cc » ('j') | content/child/web_url_loader_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/web_url_loader_impl.h

diff --git a/content/child/web_url_loader_impl.h b/content/child/web_url_loader_impl.h

index ebad018f21205c64ac762017fe606ae1a81381da..2e724b8d531e3d0965f56c06856db53ab9e8495c 100644

--- a/content/child/web_url_loader_impl.h

+++ b/content/child/web_url_loader_impl.h

@@ -36,9 +36,10 @@ struct StreamOverrideParameters {

class CONTENT_EXPORT WebURLLoaderImpl

: public NON_EXPORTED_BASE(blink::WebURLLoader) {

public:

- explicit WebURLLoaderImpl(

- ResourceDispatcher* resource_dispatcher,

- scoped_refptr<base::SingleThreadTaskRunner> task_runner);

+ // Takes ownership of |web_task_runner|.

+ WebURLLoaderImpl(ResourceDispatcher* resource_dispatcher,

+ blink::WebTaskRunner* web_task_runner);

~WebURLLoaderImpl() override;

static void PopulateURLResponse(const GURL& url,

@@ -67,6 +68,7 @@ class CONTENT_EXPORT WebURLLoaderImpl

int intra_priority_value) override;

bool attachThreadedDataReceiver(

blink::WebThreadedDataReceiver* threaded_data_receiver) override;

+ void setLoadingTaskRunner(blink::WebTaskRunner* loading_task_runner) override;

private:

class Context;