components/scheduler/child/web_task_runner_impl.h - Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/web_task_runner_impl.h

Issue 1366883002: [Reland] Post loading tasks on the appropriate WebFrameScheduler's queue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a clone method to WebTaskRunner which lets us solve the lifetime issue. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/scheduler/child/web_task_runner_impl.h

diff --git a/components/scheduler/child/web_task_runner_impl.h b/components/scheduler/child/web_task_runner_impl.h

index f1ef079da2bdd938b693bde33473dad3d733205e..587a176707cd1e649b23c26b5a030728748d6ca5 100644

--- a/components/scheduler/child/web_task_runner_impl.h

+++ b/components/scheduler/child/web_task_runner_impl.h

@@ -38,11 +38,10 @@ class SCHEDULER_EXPORT WebTaskRunnerImpl : public blink::WebTaskRunner {

void postDelayedTask(const blink::WebTraceLocation& web_location,

blink::WebTaskRunner::Task* task,

double delayMs) override;

+ blink::WebTaskRunner* clone() override;

private:

scoped_refptr<base::SingleThreadTaskRunner> task_runner_;

- DISALLOW_COPY_AND_ASSIGN(WebTaskRunnerImpl);

Sami 2015/09/29 11:22:46 We can still keep this, right?

alex clarke (OOO till 29th) 2015/09/29 16:10:36 Done.

};

} // namespace scheduler

« no previous file with comments | « no previous file | components/scheduler/child/web_task_runner_impl.cc » ('j') | content/child/blink_platform_impl.cc » ('J')