[Reland] Post loading tasks on the appropriate WebFrameScheduler's queue

content/child/blink_platform_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/blink_platform_impl.h"
 
 #include <math.h>
 
 #include <vector>
 
@@ skipping 16 matching lines @@
 #include "base/sys_info.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/platform_thread.h"
 #include "base/time/time.h"
 #include "base/trace_event/memory_allocator_dump_guid.h"
 #include "base/trace_event/memory_dump_manager.h"
 #include "base/trace_event/trace_event.h"
 #include "blink/public/resources/grit/blink_image_resources.h"
 #include "blink/public/resources/grit/blink_resources.h"
 #include "components/mime_util/mime_util.h"
+#include "components/scheduler/child/web_task_runner_impl.h"
 #include "components/scheduler/child/webthread_impl_for_worker_scheduler.h"
 #include "content/app/resources/grit/content_resources.h"
 #include "content/app/strings/grit/content_strings.h"
 #include "content/child/background_sync/background_sync_provider.h"
 #include "content/child/background_sync/background_sync_provider_thread_proxy.h"
 #include "content/child/child_thread_impl.h"
 #include "content/child/content_child_helpers.h"
 #include "content/child/geofencing/web_geofencing_provider_impl.h"
 #include "content/child/navigator_connect/service_port_provider.h"
 #include "content/child/notifications/notification_dispatcher.h"
@@ skipping 424 matching lines @@
 
 BlinkPlatformImpl::~BlinkPlatformImpl() {
 }
 
 WebURLLoader* BlinkPlatformImpl::createURLLoader() {
   ChildThreadImpl* child_thread = ChildThreadImpl::current();
   // There may be no child thread in RenderViewTests.  These tests can still use
   // data URLs to bypass the ResourceDispatcher.
   return new WebURLLoaderImpl(
       child_thread ? child_thread->resource_dispatcher() : NULL,
-      MainTaskRunnerForCurrentThread());
+      new scheduler::WebTaskRunnerImpl(LoadingTaskRunnerForCurrentThread()));

[Sami, 2015/09/29 11:22:46]

Since LoadingTaskRunnerForCurrentThread is only used here, I wonder if it would
be cleaner to just reimplement createURLLoader in RendererBlinkPlatformImpl.
WDYT?

[alex clarke (OOO till 29th), 2015/09/29 16:37:38]

Done.

 }
 
 blink::WebSocketHandle* BlinkPlatformImpl::createWebSocketHandle() {
   return new WebSocketBridge;
 }
 
 WebString BlinkPlatformImpl::userAgent() {
   return WebString::fromUTF8(GetContentClient()->GetUserAgent());
 }
 
@@ skipping 865 matching lines @@
 #endif
 }
 
 uint32_t BlinkPlatformImpl::getUniqueIdForProcess() {
   // TODO(rickyz): Replace this with base::GetUniqueIdForProcess when that's
   // ready.
   return base::trace_event::TraceLog::GetInstance()->process_id();
 }
 
 scoped_refptr<base::SingleThreadTaskRunner>
-BlinkPlatformImpl::MainTaskRunnerForCurrentThread() {
+BlinkPlatformImpl::LoadingTaskRunnerForCurrentThread() {

[Sami, 2015/09/29 11:22:46]

I think you could replace all of this with base::ThreadTaskRunnerHandle::Get().

[alex clarke (OOO till 29th), 2015/09/29 16:37:38]

Done.

   if (main_thread_task_runner_.get() &&
       main_thread_task_runner_->BelongsToCurrentThread()) {
     return main_thread_task_runner_;
   } else {
     return base::ThreadTaskRunnerHandle::Get();
   }
 }
 
 bool BlinkPlatformImpl::IsMainThread() const {
   return main_thread_task_runner_.get() &&
@@ skipping 14 matching lines @@
   return WebString::fromUTF8(ui::KeycodeConverter::DomKeyToKeyString(
       static_cast<ui::DomKey>(dom_key)));
 }
 
 int BlinkPlatformImpl::domKeyEnumFromString(const WebString& key_string) {
   return static_cast<int>(
       ui::KeycodeConverter::KeyStringToDomKey(key_string.utf8().data()));
 }
 
 }  // namespace content