Exclude about:network strings from non-chromeos builds.

Exclude about:network strings from non-chromeos builds.

chrome://network is only available on ChromeOS so other builds
should not include the strings for it.

BUG=326023
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247550

[aurimas (slooooooooow), 2014-01-27 21:08:22]

Hey Steven,

Please take a look at this change.

Thanks,
Aurimas

[aurimas (slooooooooow), 2014-01-28 17:58:20]

On 2014/01/27 21:08:22, aurimas wrote:
> Hey Steven,
> 
> Please take a look at this change.
> 
> Thanks,
> Aurimas

ping?

[stevenjb, 2014-01-28 18:24:41]

https://codereview.chromium.org/136683007/diff/1/chrome/app/chromeos_strings....
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/136683007/diff/1/chrome/app/chromeos_strings....
chrome/app/chromeos_strings.grdp:53: </message>
All of these appear to be unused and can be eliminated.

[aurimas (slooooooooow), 2014-01-28 18:30:07]

https://codereview.chromium.org/136683007/diff/1/chrome/app/chromeos_strings....
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/136683007/diff/1/chrome/app/chromeos_strings....
chrome/app/chromeos_strings.grdp:53: </message>
On 2014/01/28 18:24:43, stevenjb wrote:
> All of these appear to be unused and can be eliminated.

Done.

[stevenjb, 2014-01-28 18:43:41]

lgtm

[commit-bot: I haz the power, 2014-01-28 18:48:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/136683007/10001

[commit-bot: I haz the power, 2014-01-28 18:48:43]

Failed to apply patch for chrome/app/generated_resources.grd:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/app/generated_resources.grd
  Hunk #1 FAILED at 10008.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/app/generated_resources.grd.rej

Patch:       chrome/app/generated_resources.grd
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd
b/chrome/app/generated_resources.grd
index
ee7fd288dff89f031df6edc0b76bb73f7d58a2b7..949829a691e20c19fd71235397ffa5e175215716
100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -10008,38 +10008,6 @@ Would you like to start <ph
name="CONTROL_PANEL_APPLET_NAME">$1<ex>Add/Remove Pr
         Cancel
       </message>
 
-      <!-- chrome://network -->
-      <message name="IDS_ABOUT_AUTO_REFRESH" desc="The message to indicate that
the page is auto refreshing.">
-        (Auto-refreshing page every <ph
name="INTERVAL_SECONDS">$1<ex>10</ex></ph> seconds.)
-      </message>
-      <message name="IDS_ABOUT_AUTO_REFRESH_INFO" desc="The message to indicate
that how to auto refresh the page.">
-        (To auto-refresh this page use chrome://<ph
name="PAGE_NAME">$1<ex>network</ex></ph>/&amp;lt;secs&amp;gt;)
-      </message>
-      <message name="IDS_ABOUT_NETWORK_EVENT_LOG" desc="The section title for
the event log in the chrome://network page.">
-        Event Log (newest first):
-      </message>
-      <message name="IDS_ABOUT_NETWORK_NETWORKS" desc="The section title for
all networks in the chrome://network page.">
-        Networks:
-      </message>
-      <message name="IDS_ABOUT_NETWORK_FAVORITES" desc="The section title for
favorite networks in the chrome://network page.">
-        Favorites:
-      </message>
-      <message name="IDS_ABOUT_NETWORK_ETHERNET" desc="The section title for
ethernet networks in the chrome://network page.">
-        Ethernet Networks:
-      </message>
-      <message name="IDS_ABOUT_NETWORK_WIFI" desc="The section title for wifi
networks in the chrome://network page.">
-        Wi-Fi Networks:
-      </message>
-      <message name="IDS_ABOUT_NETWORK_CELLULAR" desc="The section title for
cellular networks in the chrome://network page.">
-        Cellular Networks:
-      </message>
-      <message name="IDS_ABOUT_NETWORK_VIRTUAL" desc="The section title for
virtual networks in the chrome://network page.">
-        Virtual Networks:
-      </message>
-      <message name="IDS_ABOUT_NETWORK_REMEMBERED_WIFI" desc="The section title
for remembered wifi networks in the chrome://network page.">
-        Remembered Wi-Fi Networks:
-      </message>
-
       <message name="IDS_OPTIONS_STARTUP_GROUP_NAME" desc="The title of the
startup group">
         On startup
       </message>

[commit-bot: I haz the power, 2014-01-29 00:43:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aurimas@chromium.org/136683007/40002

[commit-bot: I haz the power, 2014-01-29 00:57:20]

Change committed as 247550