Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 136683006: submit_try: Obtain the list of trybots from the checked-in slaves.cfg (Closed)

Created:
6 years, 11 months ago by borenet
Modified:
6 years, 11 months ago
Reviewers:
epoger, rmistry
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

submit_try: Obtain the list of trybots from the checked-in slaves.cfg This should drastically speed up the script. BUG= Committed: http://code.google.com/p/skia/source/detail?r=13071

Patch Set 1 #

Total comments: 5

Patch Set 2 : Make slaves_cfg_url global #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M tools/buildbot_globals.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/submit_try View 1 2 6 chunks +34 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
borenet
This should be independent of https://codereview.chromium.org/136823002/ and should make its testing less painful... https://codereview.chromium.org/136683006/diff/1/tools/buildbot_globals.py File ...
6 years, 11 months ago (2014-01-13 21:00:14 UTC) #1
borenet
Friendly ping
6 years, 11 months ago (2014-01-14 16:20:17 UTC) #2
epoger
On 2014/01/14 16:20:17, borenet wrote: > Friendly ping I figured I would let Ravi take ...
6 years, 11 months ago (2014-01-14 16:26:58 UTC) #3
rmistry
LGTM https://codereview.chromium.org/136683006/diff/1/tools/submit_try File tools/submit_try (right): https://codereview.chromium.org/136683006/diff/1/tools/submit_try#newcode38 tools/submit_try:38: ALL_ALIASES = [ALL_BUILDERS, COMPILE_BUILDERS, REGEX, CQ_BUILDERS] Why rearrange ...
6 years, 11 months ago (2014-01-14 17:39:54 UTC) #4
borenet
https://codereview.chromium.org/136683006/diff/1/tools/submit_try File tools/submit_try (right): https://codereview.chromium.org/136683006/diff/1/tools/submit_try#newcode38 tools/submit_try:38: ALL_ALIASES = [ALL_BUILDERS, COMPILE_BUILDERS, REGEX, CQ_BUILDERS] On 2014/01/14 17:39:54, ...
6 years, 11 months ago (2014-01-14 18:00:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/136683006/90001
6 years, 11 months ago (2014-01-14 18:40:41 UTC) #6
commit-bot: I haz the power
Failed to apply patch for tools/submit_try: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-14 18:40:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/136683006/150001
6 years, 11 months ago (2014-01-14 18:43:09 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 19:18:47 UTC) #9
Message was sent while issue was closed.
Change committed as 13071

Powered by Google App Engine
This is Rietveld 408576698