Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: service/datastore/testable.go

Issue 1366793002: Add Consistent(bool) to Testing interface (Closed) Base URL: https://github.com/luci/gae.git@move_serialization_helpers
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« service/datastore/interface.go ('K') | « service/datastore/interface.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/testable.go
diff --git a/service/datastore/testable.go b/service/datastore/testable.go
index 483cb762314814090026bde53c001029b68e83f5..0ba6c4a2c0a0e73e1a1490b529ef8d068898fb64 100644
--- a/service/datastore/testable.go
+++ b/service/datastore/testable.go
@@ -41,4 +41,11 @@ type Testable interface {
// transaction body pretending transaction conflicts happens. 0 (default)
// means commit succeeds on the first attempt (no retries).
SetTransactionRetryCount(int)
+
+ // Consistent controls the eventual consistency behavior of the testing
+ // implementation. If it is called with true, then this datastore
+ // implementation will be always-consistent, instead of eventually-consistent.
+ //
+ // By default the datastore is eventually consistent.
Vadim Sh. 2015/09/24 18:40:11 nit: mention that one has to call CatchupIndexes t
iannucci 2015/09/24 18:59:30 Done
+ Consistent(always bool)
}
« service/datastore/interface.go ('K') | « service/datastore/interface.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698