Add Consistent(bool) to Testing interface

Add Consistent(bool) to Testing interface

R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=533021
Committed: https://github.com/luci/gae/commit/a064bc77f9dfa19991a8debb4f5cb02170557ff5

[iannucci, 2015-09-24 18:32:03]

On 2015/09/24 at 00:24:11, iannucci wrote:
> 

Ping

[Vadim Sh., 2015-09-24 18:40:11]

https://codereview.chromium.org/1366793002/diff/1/impl/memory/datastore_data.go
File impl/memory/datastore_data.go (right):

https://codereview.chromium.org/1366793002/diff/1/impl/memory/datastore_data....
impl/memory/datastore_data.go:54: d.Lock()
oops.. didn't know it's under lock

https://codereview.chromium.org/1366793002/diff/1/impl/memory/datastore_data....
impl/memory/datastore_data.go:285: if cb != nil {
I think you need to call cb() len(keys) number of times even if 'ents == nil'.

https://codereview.chromium.org/1366793002/diff/1/service/datastore/datastore.go
File service/datastore/datastore.go (right):

https://codereview.chromium.org/1366793002/diff/1/service/datastore/datastore...
service/datastore/datastore.go:111: func (d *datastoreImpl) Count(q *Query)
(int64, error) {
this doesn't belong to this CL..

https://codereview.chromium.org/1366793002/diff/1/service/datastore/interface.go
File service/datastore/interface.go (right):

https://codereview.chromium.org/1366793002/diff/1/service/datastore/interface...
service/datastore/interface.go:106: Count(q *Query) (int64, error)
Is it how ndb's count() work? I though there IS magic there...

https://codereview.chromium.org/1366793002/diff/1/service/datastore/testable.go
File service/datastore/testable.go (right):

https://codereview.chromium.org/1366793002/diff/1/service/datastore/testable....
service/datastore/testable.go:49: // By default the datastore is eventually
consistent.
nit: mention that one has to call CatchupIndexes to bring it to consistent
state.

[iannucci, 2015-09-24 18:59:30]

https://codereview.chromium.org/1366793002/diff/1/impl/memory/datastore_data.go
File impl/memory/datastore_data.go (right):

https://codereview.chromium.org/1366793002/diff/1/impl/memory/datastore_data....
impl/memory/datastore_data.go:54: d.Lock()
On 2015/09/24 at 18:40:11, Vadim Sh. wrote:
> oops.. didn't know it's under lock

is ok :)

https://codereview.chromium.org/1366793002/diff/1/impl/memory/datastore_data....
impl/memory/datastore_data.go:285: if cb != nil {
On 2015/09/24 at 18:40:11, Vadim Sh. wrote:
> I think you need to call cb() len(keys) number of times even if 'ents == nil'.

oh, good catch.

https://codereview.chromium.org/1366793002/diff/1/service/datastore/datastore.go
File service/datastore/datastore.go (right):

https://codereview.chromium.org/1366793002/diff/1/service/datastore/datastore...
service/datastore/datastore.go:111: func (d *datastoreImpl) Count(q *Query)
(int64, error) {
On 2015/09/24 at 18:40:11, Vadim Sh. wrote:
> this doesn't belong to this CL..

Ok, I'll pull it out.

https://codereview.chromium.org/1366793002/diff/1/service/datastore/interface.go
File service/datastore/interface.go (right):

https://codereview.chromium.org/1366793002/diff/1/service/datastore/interface...
service/datastore/interface.go:106: Count(q *Query) (int64, error)
On 2015/09/24 at 18:40:11, Vadim Sh. wrote:
> Is it how ndb's count() work? I though there IS magic there...

So I took a look... it seems like there's actually a little bit of magic there
(but not a whole lot):
https://github.com/golang/appengine/blob/master/datastore/query.go#L335

I'll move this to RawInterface.

https://codereview.chromium.org/1366793002/diff/1/service/datastore/testable.go
File service/datastore/testable.go (right):

https://codereview.chromium.org/1366793002/diff/1/service/datastore/testable....
service/datastore/testable.go:49: // By default the datastore is eventually
consistent.
On 2015/09/24 at 18:40:11, Vadim Sh. wrote:
> nit: mention that one has to call CatchupIndexes to bring it to consistent
state.

Done

[iannucci, 2015-09-24 19:52:58]

Any more comments?

[Vadim Sh., 2015-09-24 19:58:03]

On 2015/09/24 19:52:58, iannucci wrote:
> Any more comments?

lgtm

[iannucci, 2015-09-24 20:03:43]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2015-09-24 20:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366793002/20001

[iannucci, 2015-09-24 20:06:13]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-09-24 20:06:13]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/1366793002/#ps40001
(title: "fix errcheck in test...")

[commit-bot: I haz the power, 2015-09-24 20:06:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366793002/40001

[commit-bot: I haz the power, 2015-09-24 20:10:03]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/a064bc77f9dfa19991a8debb4f5cb02170557ff5