Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: src/compiler/js-context-specialization.cc

Issue 1366753003: [turbofan] Make Node::set_op safer via wrapper. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Expand to other reducers. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/js-context-specialization.cc
diff --git a/src/compiler/js-context-specialization.cc b/src/compiler/js-context-specialization.cc
index 496d014546252282f99270137197f377c8cccaaa..adf959b247225c6b243b188d6cf1f62960cd6bd2 100644
--- a/src/compiler/js-context-specialization.cc
+++ b/src/compiler/js-context-specialization.cc
@@ -77,7 +77,7 @@ Reduction JSContextSpecialization::ReduceJSLoadContext(Node* node) {
}
const Operator* op = jsgraph_->javascript()->LoadContext(
0, access.index(), access.immutable());
- node->set_op(op);
+ NodeProperties::ChangeOp(node, op);
Jarin 2015/09/24 14:00:41 After ReplaceInput? (Here and below.)
Michael Starzinger 2015/09/24 14:21:28 Done.
node->ReplaceInput(0, jsgraph_->Constant(context));
return Changed(node);
}
@@ -119,7 +119,7 @@ Reduction JSContextSpecialization::ReduceJSStoreContext(Node* node) {
context = handle(context->previous(), isolate());
}
- node->set_op(javascript()->StoreContext(0, access.index()));
+ NodeProperties::ChangeOp(node, javascript()->StoreContext(0, access.index()));
node->ReplaceInput(0, jsgraph_->Constant(context));
return Changed(node);
}

Powered by Google App Engine
This is Rietveld 408576698