[turbofan] Make Node::set_op safer via wrapper.

src/compiler/osr.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler.h"
 #include "src/compiler/all-nodes.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/common-operator-reducer.h"
 #include "src/compiler/dead-code-elimination.h"
 #include "src/compiler/frame.h"
@@ skipping 219 matching lines @@
     TRACE(" ---- #%d:%s\n", loop_header->id(), loop_header->op()->mnemonic());
   }
 
   // Merge the ends of the graph copies.
   Node* const end = graph->end();
   int const input_count = end->InputCount();
   for (int i = 0; i < input_count; ++i) {
     NodeId const id = end->InputAt(i)->id();
     for (NodeVector* const copy : copies) {
       end->AppendInput(graph->zone(), copy->at(id));
-      end->set_op(common->End(end->InputCount()));
+      NodeProperties::ChangeOp(end, common->End(end->InputCount()));
     }
   }
 
   if (FLAG_trace_turbo_graph) {  // Simple textual RPO.
     OFStream os(stdout);
     os << "-- Graph after OSR duplication -- " << std::endl;
     os << AsRPO(*graph);
   }
 }
 
@@ skipping 43 matching lines @@
   osr_normal_entry->ReplaceUses(dead);
   osr_normal_entry->Kill();
   osr_loop_entry->ReplaceUses(graph->start());
   osr_loop_entry->Kill();
 
   // Remove the first input to the {osr_loop}.
   int const live_input_count = osr_loop->InputCount() - 1;
   CHECK_NE(0, live_input_count);
   for (Node* const use : osr_loop->uses()) {
     if (NodeProperties::IsPhi(use)) {
-      use->set_op(common->ResizeMergeOrPhi(use->op(), live_input_count));
       use->RemoveInput(0);
+      NodeProperties::ChangeOp(
+          use, common->ResizeMergeOrPhi(use->op(), live_input_count));
     }
   }
-  osr_loop->set_op(common->ResizeMergeOrPhi(osr_loop->op(), live_input_count));
   osr_loop->RemoveInput(0);
+  NodeProperties::ChangeOp(
+      osr_loop, common->ResizeMergeOrPhi(osr_loop->op(), live_input_count));
 
   // Run control reduction and graph trimming.
   // TODO(bmeurer): The OSR deconstruction could be a regular reducer and play
   // nice together with the rest, instead of having this custom stuff here.
   GraphReducer graph_reducer(tmp_zone, graph);
   DeadCodeElimination dce(&graph_reducer, graph, common);
   CommonOperatorReducer cor(&graph_reducer, graph, common, jsgraph->machine());
   graph_reducer.AddReducer(&dce);
   graph_reducer.AddReducer(&cor);
   graph_reducer.ReduceGraph();
   GraphTrimmer trimmer(tmp_zone, graph);
   NodeVector roots(tmp_zone);
   jsgraph->GetCachedNodes(&roots);
   trimmer.TrimGraph(roots.begin(), roots.end());
 }
 
 
 void OsrHelper::SetupFrame(Frame* frame) {
   // The optimized frame will subsume the unoptimized frame. Do so by reserving
   // the first spill slots.
   frame->ReserveSpillSlots(UnoptimizedFrameSlots());
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8