Issue 1366723002: Blacklist ReadPixels on GalaxyS4 due to skia:4368.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1366723002: Blacklist ReadPixels on GalaxyS4 due to skia:4368. (Closed)

Created:
5 years, 3 months ago by dogben

Modified:
5 years, 3 months ago

Reviewers:
borenet

CC:
reviews_skia.org, hal.canary

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Blacklist ReadPixels on GalaxyS4 due to skia:4368. BUG=skia:4368 Committed: https://skia.googlesource.com/skia/+/6fccec34d2f83d04aa5c1a7a663d7760769972d8

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	tools/dm_flags.json	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	tools/dm_flags.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

borenet

LGTM. Feel free to TBR this type of change if I'm not around.

5 years, 3 months ago (2015-09-24 11:41:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366723002/1

5 years, 3 months ago (2015-09-24 13:34:43 UTC) #5

dogben

On 2015/09/24 at 11:41:57, borenet wrote: > LGTM. Feel free to TBR this type of ...

5 years, 3 months ago (2015-09-24 13:35:03 UTC) #6

commit-bot: I haz the power

5 years, 3 months ago (2015-09-24 13:39:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6fccec34d2f83d04aa5c1a7a663d7760769972d8

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages