Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: components/variations/variations_associated_data.cc

Issue 1366673002: Introduce a new FieldTrialList::IsTrialActive() API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/field_trial.cc ('k') | components/variations/variations_associated_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/variations_associated_data.cc
diff --git a/components/variations/variations_associated_data.cc b/components/variations/variations_associated_data.cc
index ef86a91c9fbf75fd5e44bba0639229071bcc83c5..b4f9c00d78ce22253e4769483c0471eceabe3178 100644
--- a/components/variations/variations_associated_data.cc
+++ b/components/variations/variations_associated_data.cc
@@ -116,7 +116,7 @@ class VariationsParamAssociator {
const VariationParams& params) {
base::AutoLock scoped_lock(lock_);
- if (IsFieldTrialActive(trial_name))
+ if (base::FieldTrialList::IsTrialActive(trial_name))
return false;
const VariationKey key(trial_name, group_name);
@@ -152,18 +152,6 @@ class VariationsParamAssociator {
VariationsParamAssociator() {}
~VariationsParamAssociator() {}
- // Tests whether a field trial is active (i.e. group() has been called on it).
- // TODO(asvitkine): Expose this as an API on base::FieldTrial.
- bool IsFieldTrialActive(const std::string& trial_name) {
- base::FieldTrial::ActiveGroups active_groups;
- base::FieldTrialList::GetActiveFieldTrialGroups(&active_groups);
- for (size_t i = 0; i < active_groups.size(); ++i) {
- if (active_groups[i].trial_name == trial_name)
- return true;
- }
- return false;
- }
-
base::Lock lock_;
std::map<VariationKey, VariationParams> variation_params_;
« no previous file with comments | « base/metrics/field_trial.cc ('k') | components/variations/variations_associated_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698