Introduce a new FieldTrialList::IsTrialActive() API.

components/variations/variations_seed_processor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/variations/variations_seed_processor.h"
 
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 48 matching lines @@
 
   AddExperiment(kNonFlagGroupName, default_group_probability, &study);
   AddExperiment(kFlagGroup1Name, flag_group1_probability, &study)
       ->set_forcing_flag(kForcingFlag1);
   AddExperiment(kFlagGroup2Name, flag_group2_probability, &study)
       ->set_forcing_flag(kForcingFlag2);
 
   return study;
 }
 
-// Tests whether a field trial is active (i.e. group() has been called on it).
-bool IsFieldTrialActive(const std::string& trial_name) {
-  base::FieldTrial::ActiveGroups active_groups;
-  base::FieldTrialList::GetActiveFieldTrialGroups(&active_groups);
-  for (size_t i = 0; i < active_groups.size(); ++i) {
-    if (active_groups[i].trial_name == trial_name)
-      return true;
-  }
-  return false;
-}
-
 class TestOverrideStringCallback {
  public:
   typedef std::map<uint32_t, base::string16> OverrideMap;
 
   TestOverrideStringCallback()
       : callback_(base::Bind(&TestOverrideStringCallback::Override,
                              base::Unretained(this))) {}
 
   virtual ~TestOverrideStringCallback() {}
 
@@ skipping 354 matching lines @@
   study3->set_activation_type(Study_ActivationType_ACTIVATION_EXPLICIT);
 
   VariationsSeedProcessor seed_processor;
   seed_processor.CreateTrialsFromSeed(
       seed, "en-CA", base::Time::Now(), base::Version("20.0.0.0"),
       Study_Channel_STABLE, Study_FormFactor_DESKTOP, "", "", "",
       override_callback_.callback());
 
   // Non-specified and ACTIVATION_EXPLICIT should not start active, but
   // ACTIVATION_AUTO should.
-  EXPECT_FALSE(IsFieldTrialActive("A"));
-  EXPECT_TRUE(IsFieldTrialActive("B"));
-  EXPECT_FALSE(IsFieldTrialActive("C"));
+  EXPECT_FALSE(base::FieldTrialList::IsTrialActive("A"));
+  EXPECT_TRUE(base::FieldTrialList::IsTrialActive("B"));
+  EXPECT_FALSE(base::FieldTrialList::IsTrialActive("C"));
 
   EXPECT_EQ("AA", base::FieldTrialList::FindFullName("A"));
   EXPECT_EQ("BB", base::FieldTrialList::FindFullName("B"));
   EXPECT_EQ("CC", base::FieldTrialList::FindFullName("C"));
 
   // Now, all studies should be active.
-  EXPECT_TRUE(IsFieldTrialActive("A"));
-  EXPECT_TRUE(IsFieldTrialActive("B"));
-  EXPECT_TRUE(IsFieldTrialActive("C"));
+  EXPECT_TRUE(base::FieldTrialList::IsTrialActive("A"));
+  EXPECT_TRUE(base::FieldTrialList::IsTrialActive("B"));
+  EXPECT_TRUE(base::FieldTrialList::IsTrialActive("C"));
 }
 
 TEST_F(VariationsSeedProcessorTest, StartsActiveWithFlag) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(kForcingFlag1);
 
   base::FieldTrialList field_trial_list(NULL);
 
   Study study = CreateStudyWithFlagGroups(100, 0, 0);
   study.set_activation_type(Study_ActivationType_ACTIVATION_AUTO);
 
   EXPECT_TRUE(CreateTrialFromStudy(&study));
-  EXPECT_TRUE(IsFieldTrialActive(kFlagStudyName));
+  EXPECT_TRUE(base::FieldTrialList::IsTrialActive(kFlagStudyName));
 
   EXPECT_EQ(kFlagGroup1Name,
             base::FieldTrialList::FindFullName(kFlagStudyName));
 }
 
 TEST_F(VariationsSeedProcessorTest, ForcingFlagAlreadyForced) {
   Study study = CreateStudyWithFlagGroups(100, 0, 0);
   ASSERT_EQ(kNonFlagGroupName, study.experiment(0).name());
   Study_Experiment_Param* param = study.mutable_experiment(0)->add_param();
   param->set_name("x");
@@ skipping 10 matching lines @@
             base::FieldTrialList::FindFullName(study.name()));
 
   // Check that params and experiment ids correspond.
   EXPECT_EQ("y", GetVariationParamValue(study.name(), "x"));
   VariationID id = GetGoogleVariationID(GOOGLE_WEB_PROPERTIES, kFlagStudyName,
                                         kNonFlagGroupName);
   EXPECT_EQ(kExperimentId, id);
 }
 
 }  // namespace variations