Introduce a new FieldTrialList::IsTrialActive() API.

components/variations/variations_associated_data_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/variations/variations_associated_data.h"
 
 #include "base/metrics/field_trial.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace variations {
 
 namespace {
 
 const VariationID TEST_VALUE_A = 3300200;
 const VariationID TEST_VALUE_B = 3300201;
 
 // Convenience helper to retrieve the variations::VariationID for a FieldTrial.
 // Note that this will do the group assignment in |trial| if not already done.
 VariationID GetIDForTrial(IDCollectionKey key, base::FieldTrial* trial) {
   return GetGoogleVariationID(key, trial->trial_name(), trial->group_name());
 }
 
-// Tests whether a field trial is active (i.e. group() has been called on it).
-bool IsFieldTrialActive(const std::string& trial_name) {
-  base::FieldTrial::ActiveGroups active_groups;
-  base::FieldTrialList::GetActiveFieldTrialGroups(&active_groups);
-  for (size_t i = 0; i < active_groups.size(); ++i) {
-    if (active_groups[i].trial_name == trial_name)
-      return true;
-  }
-  return false;
-}
-
 // Call FieldTrialList::FactoryGetFieldTrial() with a future expiry date.
 scoped_refptr<base::FieldTrial> CreateFieldTrial(
     const std::string& trial_name,
     int total_probability,
     const std::string& default_group_name,
     int* default_group_number) {
   return base::FieldTrialList::FactoryGetFieldTrial(
       trial_name, total_probability, default_group_name,
       base::FieldTrialList::kNoExpirationYear, 1, 1,
       base::FieldTrial::SESSION_RANDOMIZED, default_group_number);
@@ skipping 248 matching lines @@
   std::map<std::string, std::string> params;
   params["a"] = "10";
   EXPECT_FALSE(AssociateVariationParams(kTrialName, "B", params));
   EXPECT_FALSE(AssociateVariationParams(kTrialName, "A", params));
 }
 
 TEST_F(VariationsAssociatedDataTest,
        AssociateVariationParams_DoesntActivateTrial) {
   const std::string kTrialName = "AssociateVariationParams_DoesntActivateTrial";
 
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
   scoped_refptr<base::FieldTrial> trial(
       CreateFieldTrial(kTrialName, 100, "A", NULL));
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
 
   std::map<std::string, std::string> params;
   params["a"] = "10";
   EXPECT_TRUE(AssociateVariationParams(kTrialName, "A", params));
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
 }
 
 TEST_F(VariationsAssociatedDataTest, GetVariationParams_NoTrial) {
   const std::string kTrialName = "GetVariationParams_NoParams";
 
   std::map<std::string, std::string> params;
   EXPECT_FALSE(GetVariationParams(kTrialName, &params));
   EXPECT_EQ(std::string(), GetVariationParamValue(kTrialName, "x"));
   EXPECT_EQ(std::string(), GetVariationParamValue(kTrialName, "y"));
 }
 
 TEST_F(VariationsAssociatedDataTest, GetVariationParams_NoParams) {
   const std::string kTrialName = "GetVariationParams_NoParams";
 
   base::FieldTrialList::CreateFieldTrial(kTrialName, "A");
 
   std::map<std::string, std::string> params;
   EXPECT_FALSE(GetVariationParams(kTrialName, &params));
   EXPECT_EQ(std::string(), GetVariationParamValue(kTrialName, "x"));
   EXPECT_EQ(std::string(), GetVariationParamValue(kTrialName, "y"));
 }
 
 TEST_F(VariationsAssociatedDataTest, GetVariationParams_ActivatesTrial) {
   const std::string kTrialName = "GetVariationParams_ActivatesTrial";
 
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
   scoped_refptr<base::FieldTrial> trial(
       CreateFieldTrial(kTrialName, 100, "A", NULL));
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
 
   std::map<std::string, std::string> params;
   EXPECT_FALSE(GetVariationParams(kTrialName, &params));
-  ASSERT_TRUE(IsFieldTrialActive(kTrialName));
+  ASSERT_TRUE(base::FieldTrialList::IsTrialActive(kTrialName));
 }
 
 TEST_F(VariationsAssociatedDataTest, GetVariationParamValue_ActivatesTrial) {
   const std::string kTrialName = "GetVariationParamValue_ActivatesTrial";
 
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
   scoped_refptr<base::FieldTrial> trial(
       CreateFieldTrial(kTrialName, 100, "A", NULL));
-  ASSERT_FALSE(IsFieldTrialActive(kTrialName));
+  ASSERT_FALSE(base::FieldTrialList::IsTrialActive(kTrialName));
 
   std::map<std::string, std::string> params;
   EXPECT_EQ(std::string(), GetVariationParamValue(kTrialName, "x"));
-  ASSERT_TRUE(IsFieldTrialActive(kTrialName));
+  ASSERT_TRUE(base::FieldTrialList::IsTrialActive(kTrialName));
 }
 
 }  // namespace variations