Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1366653003: [Chromecast] Replace 'fontconfig' GN target with dynamic dependency. (Closed)

Created:
5 years, 3 months ago by slan
Modified:
5 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Replace 'fontconfig' GN target with dynamic dependency. Chromecast needs to be able to optionally use //third_party/fontconfig instead of system headers. This CL acheives parity with the GYP build for this feature: https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/system.gyp&l=748 BUG=516899 Committed: https://crrev.com/17e5ce7ff587612814565e8fa2d737e76feb3e56 Cr-Commit-Position: refs/heads/master@{#350711}

Patch Set 1 #

Patch Set 2 : Rebase + WebKit update #

Patch Set 3 : Correct dep in //chrome/browser/chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -68 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/BUILD.gn View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 11 chunks +43 lines, -46 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366653003/1
5 years, 3 months ago (2015-09-23 18:03:30 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 3 months ago (2015-09-23 18:03:32 UTC) #4
slan
Chromecast would like to depend on //third_party/fontconfig for internal ARM builds, rather than provide headers. ...
5 years, 3 months ago (2015-09-23 21:44:16 UTC) #6
Dirk Pranke
lgtm.
5 years, 3 months ago (2015-09-24 19:29:48 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366653003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366653003/20001
5 years, 3 months ago (2015-09-24 19:39:06 UTC) #9
brettw
lgtm
5 years, 3 months ago (2015-09-24 19:43:13 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/85912)
5 years, 3 months ago (2015-09-24 19:53:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366653003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366653003/40001
5 years, 3 months ago (2015-09-24 21:51:34 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-25 00:04:53 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 00:05:57 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/17e5ce7ff587612814565e8fa2d737e76feb3e56
Cr-Commit-Position: refs/heads/master@{#350711}

Powered by Google App Engine
This is Rietveld 408576698