third_party/WebKit/Source/bindings/templates/interface_base.cpp - Issue 1366643003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 1366643003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp b/third_party/WebKit/Source/bindings/templates/interface_base.cpp

index 3f4e4511ea482a2666ffa5ce84cb8c764a8e155b..9716125107801ce15d1b788bd74c28fc4bd5b021 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp

@@ -472,6 +472,13 @@ static void install{{v8_class}}Template(v8::Local<v8::FunctionTemplate> function

functionTemplate->SetHiddenPrototype(true);

{% endif %}

+ {# Willful violation of WebIDL 4.5.4 and 4.7 - implement the class string

+ for interfaces via @@toStringTag on the prototype. WebIDL requires

+ @@toStringTag instances and prototype (with 'Prototype' appended) but

+ this has performance concerns and may not be necessary for web compat.

+ https://www.w3.org/Bugs/Public/show_bug.cgi?id=28244 #}

+ prototypeTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "{{interface_name}}"));

// Custom toString template

functionTemplate->Set(v8AtomicString(isolate, "toString"), V8PerIsolateData::from(isolate)->toStringTemplate());

{% endif %}