components/metrics/system_memory_stats_recorder.h - Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/system_memory_stats_recorder.h

Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/stability_metrics_helper_unittest.cc ('k') | components/metrics/system_memory_stats_recorder_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/system_memory_stats_recorder.h

diff --git a/chrome/browser/memory/system_memory_stats_recorder.h b/components/metrics/system_memory_stats_recorder.h

similarity index 77%

rename from chrome/browser/memory/system_memory_stats_recorder.h

rename to components/metrics/system_memory_stats_recorder.h

index 5dc354067575c0779b5be6737eb5ec78ddf8daad..bdd30f00f4252004272d50c0644ca762bb0e15f1 100644

--- a/chrome/browser/memory/system_memory_stats_recorder.h

+++ b/components/metrics/system_memory_stats_recorder.h

@@ -2,10 +2,10 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef CHROME_BROWSER_MEMORY_SYSTEM_MEMORY_STATS_RECORDER_H_

-#define CHROME_BROWSER_MEMORY_SYSTEM_MEMORY_STATS_RECORDER_H_

+#ifndef COMPONENTS_METRICS_SYSTEM_MEMORY_STATS_RECORDER_H_

+#define COMPONENTS_METRICS_SYSTEM_MEMORY_STATS_RECORDER_H_

-namespace memory {

+namespace metrics {

// Record a memory size in megabytes, over a potential interval up to 32 GB.

#define UMA_HISTOGRAM_LARGE_MEMORY_MB(name, sample) \

@@ -25,6 +25,6 @@ enum RecordMemoryStatsType {

void RecordMemoryStats(RecordMemoryStatsType type);

-} // namespace memory

+} // namespace metrics

-#endif // CHROME_BROWSER_MEMORY_SYSTEM_MEMORY_STATS_RECORDER_H_

+#endif // COMPONENTS_METRICS_SYSTEM_MEMORY_STATS_RECORDER_H_