chrome/browser/memory/tab_manager.cc - Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/memory/tab_manager.cc

Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/memory/system_memory_stats_recorder_win.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/memory/tab_manager.cc

diff --git a/chrome/browser/memory/tab_manager.cc b/chrome/browser/memory/tab_manager.cc

index d21700f63e6d39b9250f7d4e04da7386d968cae5..63000f6354e8ca17664a83cd6144351de010c270 100644

--- a/chrome/browser/memory/tab_manager.cc

+++ b/chrome/browser/memory/tab_manager.cc

@@ -26,7 +26,6 @@

#include "build/build_config.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/memory/oom_memory_details.h"

-#include "chrome/browser/memory/system_memory_stats_recorder.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_list.h"

@@ -37,6 +36,7 @@

#include "chrome/browser/ui/tabs/tab_utils.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/url_constants.h"

+#include "components/metrics/system_memory_stats_recorder.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/web_contents.h"

@@ -293,7 +293,7 @@ void TabManager::RecordDiscardStatistics() {

// all platforms.

#if defined(OS_WIN) || defined(OS_CHROMEOS)

// Record system memory usage at the time of the discard.

- RecordMemoryStats(RECORD_MEMORY_STATS_TAB_DISCARDED);

+ metrics::RecordMemoryStats(metrics::RECORD_MEMORY_STATS_TAB_DISCARDED);

#endif

// Set up to record the next interval.

last_discard_time_ = TimeTicks::Now();