components/metrics/BUILD.gn - Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/BUILD.gn

Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More build fixes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_stability_metrics_provider.cc ('K') | « components/metrics.gypi ('k') | components/metrics/metrics_pref_names.h » ('j') | components/metrics/stability_metrics_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/BUILD.gn

diff --git a/components/metrics/BUILD.gn b/components/metrics/BUILD.gn

index 5552136e64ebc7cbad70f16ca6a05932c10cea7e..354ae3a45530c6a712bf33ae0a3782441bf7123e 100644

--- a/components/metrics/BUILD.gn

+++ b/components/metrics/BUILD.gn

@@ -53,6 +53,11 @@ source_set("metrics") {

"metrics_switches.h",

"persisted_logs.cc",

"persisted_logs.h",

+ "stability_metrics_helper.cc",

+ "stability_metrics_helper.h",

+ "system_memory_stats_recorder.h",

+ "system_memory_stats_recorder_linux.cc",

+ "system_memory_stats_recorder_win.cc",

"url_constants.cc",

"url_constants.h",

]

@@ -193,6 +198,7 @@ source_set("unit_tests") {

"metrics_state_manager_unittest.cc",

"net/net_metrics_log_uploader_unittest.cc",

"persisted_logs_unittest.cc",

+ "stability_metrics_helper_unittest.cc",

]

deps = [