chrome/common/pref_names.h - Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/pref_names.h

Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More build fixes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_stability_metrics_provider.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/common/pref_names.cc » ('j') | components/metrics/stability_metrics_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/pref_names.h

diff --git a/chrome/common/pref_names.h b/chrome/common/pref_names.h

index a8c27b069bacbc58601aa82bd120fac5bcb6499b..ebd38dd16218fa9df34dfd07f562642f0226865f 100644

--- a/chrome/common/pref_names.h

+++ b/chrome/common/pref_names.h

@@ -450,13 +450,6 @@ extern const char kProfileInfoCache[];

extern const char kProfileCreatedByVersion[];

extern const char kProfileResetPromptMementosInLocalState[];

-extern const char kStabilityPageLoadCount[];

-extern const char kStabilityRendererCrashCount[];

-extern const char kStabilityRendererFailedLaunchCount[];

-extern const char kStabilityExtensionRendererCrashCount[];

-extern const char kStabilityExtensionRendererFailedLaunchCount[];

-extern const char kStabilityRendererHangCount[];

-extern const char kStabilityChildProcessCrashCount[];

extern const char kStabilityOtherUserCrashCount[];

extern const char kStabilityKernelCrashCount[];

extern const char kStabilitySystemUncleanShutdownCount[];

@@ -474,7 +467,6 @@ extern const char kStabilityPluginInstances[];

extern const char kStabilityPluginCrashes[];

extern const char kStabilityPluginLoadingErrors[];

-extern const char kUninstallMetricsPageLoadCount[];

extern const char kUninstallLastLaunchTimeSec[];

extern const char kUninstallLastObservedRunTimeSec[];