chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1366643002: Extract guts of ChromeStabilityMetricsProvider into helper class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More build fixes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/memory/system_memory_stats_recorder_win.cc ('k') | chrome/browser/metrics/chrome_stability_metrics_provider.h » ('j') | chrome/browser/metrics/chrome_stability_metrics_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index bf5b391e864a70a2e449a5547e18cd2c5a434c6b..0be4424f9f2f7ebdebb7bf1caff728ce8312af8b 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -38,6 +38,7 @@

#include "components/metrics/net/network_metrics_provider.h"

#include "components/metrics/profiler/profiler_metrics_provider.h"

#include "components/metrics/profiler/tracking_synchronizer.h"

+#include "components/metrics/stability_metrics_helper.h"

#include "components/metrics/url_constants.h"

#include "components/omnibox/browser/omnibox_metrics_provider.h"

#include "components/variations/variations_associated_data.h"

@@ -168,7 +169,7 @@ void ChromeMetricsServiceClient::RegisterPrefs(PrefRegistrySimple* registry) {

registry->RegisterInt64Pref(prefs::kUninstallLastObservedRunTimeSec, 0);

metrics::MetricsService::RegisterPrefs(registry);

- ChromeStabilityMetricsProvider::RegisterPrefs(registry);

+ metrics::StabilityMetricsHelper::RegisterPrefs(registry);

#if defined(OS_ANDROID)

AndroidMetricsProvider::RegisterPrefs(registry);