Extract guts of ChromeStabilityMetricsProvider into helper class

chrome/browser/metrics/metrics_service_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests the MetricsService stat recording to make sure that the numbers are
 // what we expect.
 
 #include "components/metrics/metrics_service.h"
 
 #include <string>
@@ skipping 47 matching lines @@
         kBrowserTestFlags);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, CloseRenderersNormally) {
   OpenTabs();
 
   // Verify that the expected stability metrics were recorded.
   const PrefService* prefs = g_browser_process->local_state();
   EXPECT_EQ(1, prefs->GetInteger(metrics::prefs::kStabilityLaunchCount));
-  EXPECT_EQ(3, prefs->GetInteger(prefs::kStabilityPageLoadCount));
-  EXPECT_EQ(0, prefs->GetInteger(prefs::kStabilityRendererCrashCount));
+  EXPECT_EQ(3, prefs->GetInteger(metrics::prefs::kStabilityPageLoadCount));
+  EXPECT_EQ(0, prefs->GetInteger(metrics::prefs::kStabilityRendererCrashCount));
   // TODO(isherman): We should also verify that
   // metrics::prefs::kStabilityExitedCleanly
   // is set to true, but this preference isn't set until the browser
   // exits... it's not clear to me how to test that.
 }
 
 // Flaky on Linux. See http://crbug.com/131094
 // Child crashes fail the process on ASan (see crbug.com/411251,
 // crbug.com/368525).
 #if defined(OS_LINUX) || defined(ADDRESS_SANITIZER)
@@ skipping 11 matching lines @@
   ui_test_utils::NavigateToURL(browser(), GURL(content::kChromeUICrashURL));
   observer.Wait();
 
   // The MetricsService listens for the same notification, so the |observer|
   // might finish waiting before the MetricsService has a chance to process the
   // notification.  To avoid racing here, we repeatedly run the message loop
   // until the MetricsService catches up.  This should happen "real soon now",
   // since the notification is posted to all observers essentially
   // simultaneously... so busy waiting here shouldn't be too bad.
   const PrefService* prefs = g_browser_process->local_state();
-  while (!prefs->GetInteger(prefs::kStabilityRendererCrashCount)) {
+  while (!prefs->GetInteger(metrics::prefs::kStabilityRendererCrashCount)) {
     content::RunAllPendingInMessageLoop();
   }
 
   // Verify that the expected stability metrics were recorded.
   EXPECT_EQ(1, prefs->GetInteger(metrics::prefs::kStabilityLaunchCount));
-  EXPECT_EQ(4, prefs->GetInteger(prefs::kStabilityPageLoadCount));
-  EXPECT_EQ(1, prefs->GetInteger(prefs::kStabilityRendererCrashCount));
+  EXPECT_EQ(4, prefs->GetInteger(metrics::prefs::kStabilityPageLoadCount));
+  EXPECT_EQ(1, prefs->GetInteger(metrics::prefs::kStabilityRendererCrashCount));
   // TODO(isherman): We should also verify that
   // metrics::prefs::kStabilityExitedCleanly
   // is set to true, but this preference isn't set until the browser
   // exits... it's not clear to me how to test that.
 }