Reland "[turbofan] Checking of input counts on node creation"

test/cctest/compiler/test-simplified-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits>
 
 #include "src/compiler/access-builder.h"
 #include "src/compiler/change-lowering.h"
 #include "src/compiler/control-builders.h"
 #include "src/compiler/graph-reducer.h"
@@ skipping 1201 matching lines @@
   CheckChangeInsertion(IrOpcode::kChangeUint32ToFloat64, kTypeUint32,
                        kRepFloat64);
   CheckChangeInsertion(IrOpcode::kChangeUint32ToTagged, kTypeUint32,
                        kRepTagged);
 }
 
 
 static void CheckChangesAroundBinop(TestingGraph* t, const Operator* op,
                                     IrOpcode::Value input_change,
                                     IrOpcode::Value output_change) {
-  Node* binop = t->graph()->NewNode(op, t->p0, t->p1);
+  Node* binop =
+      op->ControlInputCount() == 0
+          ? t->graph()->NewNode(op, t->p0, t->p1)
+          : t->graph()->NewNode(op, t->p0, t->p1, t->graph()->start());
   t->Return(binop);
   t->Lower();
   CHECK_EQ(input_change, binop->InputAt(0)->opcode());
   CHECK_EQ(input_change, binop->InputAt(1)->opcode());
   CHECK_EQ(t->p0, binop->InputAt(0)->InputAt(0));
   CHECK_EQ(t->p1, binop->InputAt(1)->InputAt(0));
   CHECK_EQ(output_change, t->ret->InputAt(0)->opcode());
   CHECK_EQ(binop, t->ret->InputAt(0)->InputAt(0));
 }
 
@@ skipping 751 matching lines @@
     Type* phi_type = Type::Union(d.arg1, d.arg2, z);
     NodeProperties::SetType(phi, phi_type);
 
     Node* use = t.Use(phi, d.use);
     t.Return(use);
     t.Lower();
 
     CHECK_EQ(d.expected, OpParameter<MachineType>(phi));
   }
 }