Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1366543003: Reland "[turbofan] Checking of input counts on node creation" (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[turbofan] Checking of input counts on node creation" (Original CL: https://codereview.chromium.org/1347353003/) Unfortunately, the mips gcc gets confused by arraysize on variadic templated arguments, so we use sizeof... instead. Committed: https://crrev.com/205d85affc739b8242ce63b58d96b0674f564d9f Cr-Commit-Position: refs/heads/master@{#30880}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -458 lines) Patch
M src/compiler/basic-block-instrumentor.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/graph.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/graph.cc View 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 12 chunks +115 lines, -139 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 15 chunks +33 lines, -48 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 2 chunks +15 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-js-constant-cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-js-context-specialization.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 4 chunks +24 lines, -14 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 38 chunks +133 lines, -122 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 18 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 4 chunks +7 lines, -19 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 3 chunks +9 lines, -21 lines 0 comments Download
M test/unittests/compiler/liveness-analyzer-unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/unittests/compiler/loop-peeling-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 2 chunks +18 lines, -2 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 3 months ago (2015-09-23 08:44:49 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-23 08:57:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366543003/20001
5 years, 3 months ago (2015-09-23 08:58:27 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 09:08:22 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 09:08:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/205d85affc739b8242ce63b58d96b0674f564d9f
Cr-Commit-Position: refs/heads/master@{#30880}

Powered by Google App Engine
This is Rietveld 408576698