A64: Synchronize with r18256.

src/a64/stub-cache-a64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 686 matching lines @@
 void StoreStubCompiler::GenerateRestoreName(MacroAssembler* masm,
                                             Label* label,
                                             Handle<Name> name) {
   if (!label->is_unused()) {
     __ Bind(label);
     __ Mov(this->name(), Operand(name));
   }
 }
 
 
-// The function to called must be passed in x1.
-static void GenerateCallFunction(MacroAssembler* masm,
-                                 Handle<Object> object,
-                                 const ParameterCount& arguments,
-                                 Label* miss,
-                                 ExtraICState extra_ic_state,
-                                 Register function,
-                                 Register receiver,
-                                 Register scratch) {
-  ASSERT(!AreAliased(function, receiver, scratch));
-  ASSERT(function.Is(x1));
-
-  // Check that the function really is a function.
-  __ JumpIfSmi(function, miss);
-  __ JumpIfNotObjectType(function, scratch, scratch, JS_FUNCTION_TYPE, miss);
-
-  if (object->IsGlobalObject()) {
-    const int argc = arguments.immediate();
-    const int receiver_offset = argc * kPointerSize;
-    __ Ldr(scratch,
-           FieldMemOperand(receiver, GlobalObject::kGlobalReceiverOffset));
-    __ Poke(scratch, receiver_offset);
-  }
-
-  // Invoke the function.
-  CallKind call_kind = CallICBase::Contextual::decode(extra_ic_state)
-      ? CALL_AS_FUNCTION
-      : CALL_AS_METHOD;
-  __ InvokeFunction(
-      function, arguments, JUMP_FUNCTION, NullCallWrapper(), call_kind);
-}
-
-
 static void PushInterceptorArguments(MacroAssembler* masm,
                                      Register receiver,
                                      Register holder,
                                      Register name,
                                      Handle<JSObject> holder_obj) {
   STATIC_ASSERT(StubCache::kInterceptorArgsNameIndex == 0);
   STATIC_ASSERT(StubCache::kInterceptorArgsInfoIndex == 1);
   STATIC_ASSERT(StubCache::kInterceptorArgsThisIndex == 2);
   STATIC_ASSERT(StubCache::kInterceptorArgsHolderIndex == 3);
   STATIC_ASSERT(StubCache::kInterceptorArgsLength == 4);
@@ skipping 181 matching lines @@
     ASSERT(!AreAliased(receiver, scratch, values[i]));
     __ Poke(receiver, index-- * kPointerSize);
   }
 
   GenerateFastApiDirectCall(masm, optimization, argc, true);
 }
 
 
 class CallInterceptorCompiler BASE_EMBEDDED {
  public:
-  CallInterceptorCompiler(StubCompiler* stub_compiler,
+  CallInterceptorCompiler(CallStubCompiler* stub_compiler,
                           const ParameterCount& arguments,
                           Register name,
                           ExtraICState extra_ic_state)
       : stub_compiler_(stub_compiler),
         arguments_(arguments),
         name_(name),
         extra_ic_state_(extra_ic_state) {}
 
   void Compile(MacroAssembler* masm,
                Handle<JSObject> object,
@@ skipping 94 matching lines @@
       // safe to omit it here, as if present, it should be fetched
       // by the previous CheckPrototypes.
       ASSERT(depth2 == kInvalidProtoDepth);
     }
 
     // Invoke function.
     if (can_do_fast_api_call) {
       GenerateFastApiDirectCall(
           masm, optimization, arguments_.immediate(), false);
     } else {
-      CallKind call_kind = CallICBase::Contextual::decode(extra_ic_state_)
-          ? CALL_AS_FUNCTION
-          : CALL_AS_METHOD;
       Handle<JSFunction> function = optimization.constant_function();
-      ParameterCount expected(function);
-      __ InvokeFunction(function, expected, arguments_,
-                        JUMP_FUNCTION, NullCallWrapper(), call_kind);
+      stub_compiler_->GenerateJumpFunctionIgnoreReceiver(function);
     }
 
     // Deferred code for fast API call case, clean preallocated space.
     if (can_do_fast_api_call) {
       __ Bind(&miss_cleanup);
       FreeSpaceForFastApiCall(masm);
       __ B(miss_label);
     }
 
     // Invoke a regular function.
@@ skipping 44 matching lines @@
           IC::kLoadPropertyWithInterceptorOnly);
       __ Pop(name_, receiver);
     }
 
     // If interceptor returns no-result sentinel, call the constant function.
     __ JumpIfNotRoot(x0,
                      Heap::kNoInterceptorResultSentinelRootIndex,
                      interceptor_succeeded);
   }
 
-  StubCompiler* stub_compiler_;
+  CallStubCompiler* stub_compiler_;
   const ParameterCount& arguments_;
   Register name_;
   ExtraICState extra_ic_state_;
 };
 
 
 void StubCompiler::GenerateTailCall(MacroAssembler* masm, Handle<Code> code) {
   __ Jump(code, RelocInfo::CODE_TARGET);
 }
 
@@ skipping 424 matching lines @@
 void CallStubCompiler::GenerateNameCheck(Handle<Name> name, Label* miss) {
   Register name_reg = x2;
 
   if (kind_ == Code::KEYED_CALL_IC) {
     __ Cmp(name_reg, Operand(name));
     __ B(ne, miss);
   }
 }
 
 
+void CallStubCompiler::GenerateFunctionCheck(Register function,
+                                             Register scratch,
+                                             Label* miss) {
+  __ JumpIfSmi(function, miss);
+  __ JumpIfNotObjectType(function, scratch, scratch, JS_FUNCTION_TYPE, miss);
+}
+
+
 // Load the function object into x1 register.
 void CallStubCompiler::GenerateLoadFunctionFromCell(
     Handle<Cell> cell,
     Handle<JSFunction> function,
     Label* miss) {
   // Get the value from the cell.
   __ Mov(x3, Operand(cell));
   Register function_reg = x1;
   __ Ldr(function_reg, FieldMemOperand(x3, Cell::kValueOffset));
 
   // Check that the cell contains the same function.
   if (heap()->InNewSpace(*function)) {
     // We can't embed a pointer to a function in new space so we have
     // to verify that the shared function info is unchanged. This has
     // the nice side effect that multiple closures based on the same
     // function can all use this call IC. Before we load through the
     // function, we have to verify that it still is a function.
-    __ JumpIfSmi(function_reg, miss);
-    __ JumpIfNotObjectType(function_reg, x3, x3, JS_FUNCTION_TYPE, miss);
+    GenerateFunctionCheck(function_reg, x3, miss);
 
     // Check the shared function info. Make sure it hasn't changed.
     __ Mov(x3, Operand(Handle<SharedFunctionInfo>(function->shared())));
     __ Ldr(x4,
         FieldMemOperand(function_reg, JSFunction::kSharedFunctionInfoOffset));
     __ Cmp(x4, x3);
   } else {
     __ Cmp(function_reg, Operand(function));
   }
   __ B(ne, miss);
 }
 
 
 void CallStubCompiler::GenerateMissBranch() {
   Handle<Code> code =
       isolate()->stub_cache()->ComputeCallMiss(arguments().immediate(),
                                                kind_,
-                                               extra_state_);
+                                               extra_state());
   __ Jump(code, RelocInfo::CODE_TARGET);
 }
 
 
 Handle<Code> CallStubCompiler::CompileCallField(Handle<JSObject> object,
                                                 Handle<JSObject> holder,
                                                 PropertyIndex index,
                                                 Handle<Name> name) {
   Label miss;
-  Register receiver = x0;
   Register function = x1;
 
   Register holder_reg = HandlerFrontendHeader(
       object, holder, name, RECEIVER_MAP_CHECK, &miss);
 
   GenerateFastPropertyLoad(masm(), function, holder_reg,
                            index.is_inobject(holder),
                            index.translate(holder),
                            Representation::Tagged());
-
-  GenerateCallFunction(
-      masm(), object, arguments(), &miss, extra_state_, function, receiver, x3);
+  GenerateJumpFunction(object, function, &miss);
 
   HandlerFrontendFooter(&miss);
 
   // Return the generated code.
   return GetCode(Code::FAST, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileArrayCodeCall(
     Handle<Object> object,
@@ skipping 28 matching lines @@
 }
 
 
 Handle<Code> CallStubCompiler::CompileArrayPushCall(
     Handle<Object> object,
     Handle<JSObject> holder,
     Handle<Cell> cell,
     Handle<JSFunction> function,
     Handle<String> name,
     Code::StubType type) {
-  // If object is not an array or is observed, bail out to regular call.
+  // If object is not an array or is observed or sealed, bail out to regular
+  // call.
   if (!object->IsJSArray() ||
       !cell.is_null() ||
-      Handle<JSArray>::cast(object)->map()->is_observed()) {
+      Handle<JSArray>::cast(object)->map()->is_observed() ||
+      !Handle<JSArray>::cast(object)->map()->is_extensible()) {
     return Handle<Code>::null();
   }
 
   Label miss;
 
   HandlerFrontendHeader(object, holder, name, RECEIVER_MAP_CHECK, &miss);
 
   Register receiver = x0;
 
   const int argc = arguments().immediate();
@@ skipping 235 matching lines @@
 }
 
 
 Handle<Code> CallStubCompiler::CompileArrayPopCall(
     Handle<Object> object,
     Handle<JSObject> holder,
     Handle<Cell> cell,
     Handle<JSFunction> function,
     Handle<String> name,
     Code::StubType type) {
-  // If object is not an array or is observed, bail out to regular call.
+  // If object is not an array or is observed or sealed, bail out to regular
+  // call.
   if (!object->IsJSArray() ||
       !cell.is_null() ||
-      Handle<JSArray>::cast(object)->map()->is_observed()) {
+      Handle<JSArray>::cast(object)->map()->is_observed() ||
+      !Handle<JSArray>::cast(object)->map()->is_extensible()) {
     return Handle<Code>::null();
   }
 
   const int argc = arguments().immediate();
   Label miss, return_undefined, call_builtin;
   Register receiver = x0;
   Register result = x1;
   Register elements = x3;
   Register length = x4;
 
@@ skipping 55 matching lines @@
     Code::StubType type) {
   // If object is not a string, bail out to regular call.
   if (!object->IsString() || !cell.is_null()) return Handle<Code>::null();
 
   Label miss;
   Label name_miss;
   Label index_out_of_range;
   Label* index_out_of_range_label = &index_out_of_range;
 
   if (kind_ == Code::CALL_IC &&
-      (CallICBase::StringStubState::decode(extra_state_) ==
+      (CallICBase::StringStubState::decode(extra_state()) ==
        DEFAULT_STRING_STUB)) {
     index_out_of_range_label = &miss;
   }
   HandlerFrontendHeader(object, holder, name, STRING_CHECK, &name_miss);
 
   Register receiver = x0;
   Register result = x1;
   Register index = x4;
 
   const int argc = arguments().immediate();
@@ skipping 22 matching lines @@
   if (index_out_of_range.is_linked()) {
     __ Bind(&index_out_of_range);
     __ LoadRoot(x0, Heap::kNanValueRootIndex);
     __ Drop(argc + 1);
     __ Ret();
   }
 
   __ Bind(&miss);
   // Restore function name in x2.
   __ Mov(x2, Operand(name));
-  __ Bind(&name_miss);
-  GenerateMissBranch();
+  HandlerFrontendFooter(&name_miss);
 
   // Return the generated code.
   return GetCode(type, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileStringCharAtCall(
     Handle<Object> object,
     Handle<JSObject> holder,
     Handle<Cell> cell,
     Handle<JSFunction> function,
     Handle<String> name,
     Code::StubType type) {
   // If object is not a string, bail out to regular call.
   if (!object->IsString() || !cell.is_null()) return Handle<Code>::null();
 
   const int argc = arguments().immediate();
   Label miss;
   Label name_miss;
   Label index_out_of_range;
   Label* index_out_of_range_label = &index_out_of_range;
 
   if (kind_ == Code::CALL_IC &&
-      (CallICBase::StringStubState::decode(extra_state_) ==
+      (CallICBase::StringStubState::decode(extra_state()) ==
        DEFAULT_STRING_STUB)) {
     index_out_of_range_label = &miss;
   }
 
   HandlerFrontendHeader(object, holder, name, STRING_CHECK, &name_miss);
 
   Register receiver = x0;
   Register index = x4;
   Register scratch = x3;
   Register result = x1;
@@ skipping 23 matching lines @@
   if (index_out_of_range.is_linked()) {
     __ Bind(&index_out_of_range);
     __ LoadRoot(x0, Heap::kempty_stringRootIndex);
     __ Drop(argc + 1);
     __ Ret();
   }
 
   __ Bind(&miss);
   // Restore function name in x2.
   __ Mov(x2, Operand(name));
-  __ Bind(&name_miss);
-  GenerateMissBranch();
+  HandlerFrontendFooter(&name_miss);
 
   // Return the generated code.
   return GetCode(type, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileStringFromCharCodeCall(
     Handle<Object> object,
     Handle<JSObject> holder,
     Handle<Cell> cell,
@@ skipping 27 matching lines @@
 
   Register result = x0;
   StringCharFromCodeGenerator generator(code, result);
   generator.GenerateFast(masm());
   __ Drop(argc + 1);
   __ Ret();
 
   StubRuntimeCallHelper call_helper;
   generator.GenerateSlow(masm(), call_helper);
 
-  // Tail call the full function. We do not have to patch the receiver
-  // because the function makes no use of it.
   __ Bind(&slow);
-  ParameterCount expected(function);
-  __ InvokeFunction(function, expected, arguments(),
-                    JUMP_FUNCTION, NullCallWrapper(), CALL_AS_METHOD);
+  // We do not have to patch the receiver because the function makes no use of
+  // it.
+  GenerateJumpFunctionIgnoreReceiver(function);
 
   HandlerFrontendFooter(&miss);
 
   // Return the generated code.
   return GetCode(type, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileMathFloorCall(
     Handle<Object> object,
@@ skipping 74 matching lines @@
 
   __ Bind(&smi_result);
   // Tag and return the result.
   __ SmiTag(result, int_value);
 
   __ Bind(&return_result);
   __ Drop(argc + 1);
   __ Ret();
 
   __ Bind(&slow);
-  // Tail call the full function. We do not have to patch the receiver
-  // because the function makes no use of it.
-  ParameterCount expected(function);
-  __ InvokeFunction(function, expected, arguments(),
-                    JUMP_FUNCTION, NullCallWrapper(), CALL_AS_METHOD);
+  // We do not have to patch the receiver because the function makes no use of
+  // it.
+  GenerateJumpFunctionIgnoreReceiver(function);
 
   HandlerFrontendFooter(&miss);
 
   // Return the generated code.
   return GetCode(type, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileMathAbsCall(
     Handle<Object> object,
@@ skipping 43 matching lines @@
   __ Ret();
 
   __ Bind(&negative_sign);
   FPRegister double_value = d0;
   __ Fmov(double_value, value);
   __ Fabs(double_value, double_value);
   __ AllocateHeapNumberWithValue(result, double_value, &slow, x1, x3);
   __ Drop(argc + 1);
   __ Ret();
 
-  // Tail call the full function. We do not have to patch the receiver
-  // because the function makes no use of it.
   __ Bind(&slow);
-  ParameterCount expected(function);
-  __ InvokeFunction(function, expected, arguments(),
-                    JUMP_FUNCTION, NullCallWrapper(), CALL_AS_METHOD);
+  // We do not have to patch the receiver because the function makes no use of
+  // it.
+  GenerateJumpFunctionIgnoreReceiver(function);
 
   HandlerFrontendFooter(&miss);
 
   // Return the generated code.
   return GetCode(type, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileFastApiCall(
     const CallOptimization& optimization,
@@ skipping 33 matching lines @@
 
   // Check that the maps haven't changed and find a Holder as a side effect.
   CheckPrototypes(IC::CurrentTypeOf(object, isolate()),
                   receiver, holder, x0, x3, x4, name, depth, &miss);
 
   GenerateFastApiDirectCall(masm(), optimization, argc, false);
 
   __ Bind(&miss);
   FreeSpaceForFastApiCall(masm());
 
-  __ Bind(&miss_before_stack_reserved);
-  GenerateMissBranch();
+  HandlerFrontendFooter(&miss_before_stack_reserved);
 
   // Return the generated code.
   return GetCode(function);
 }
 
 
 void StubCompiler::GenerateBooleanCheck(Register object, Label* miss) {
   Label success;
   // Check that the object is a boolean.
   // TODO(all): Optimize this like LCodeGen::DoDeferredTaggedToI.
@@ skipping 93 matching lines @@
     Handle<Object> prototype(object->GetPrototype(isolate()), isolate());
     receiver = CheckPrototypes(
         IC::CurrentTypeOf(prototype, isolate()),
         prototype_reg, holder, x1, x3, x4, name, miss);
   }
 
   return receiver;
 }
 
 
-void CallStubCompiler::CompileHandlerBackend(Handle<JSFunction> function) {
-  CallKind call_kind = CallICBase::Contextual::decode(extra_state_)
-      ? CALL_AS_FUNCTION
-      : CALL_AS_METHOD;
-  ParameterCount expected(function);
-  __ InvokeFunction(function, expected, arguments(),
-                    JUMP_FUNCTION, NullCallWrapper(), call_kind);
+void CallStubCompiler::GenerateJumpFunction(Handle<Object> object,
+                                            Register function,
+                                            Label* miss) {
+  ASSERT(function.Is(x1));
+  // Check that the function really is a function.
+  GenerateFunctionCheck(function, x3, miss);
+  PatchGlobalProxy(object);
+
+  // Invoke the function.
+  __ InvokeFunction(function, arguments(), JUMP_FUNCTION,
+                    NullCallWrapper(), call_kind());
 }
 
 
-Handle<Code> CallStubCompiler::CompileCallConstant(
-    Handle<Object> object,
-    Handle<JSObject> holder,
-    Handle<Name> name,
-    CheckType check,
-    Handle<JSFunction> function) {
-  if (HasCustomCallGenerator(function)) {
-    Handle<Code> code = CompileCustomCall(object, holder,
-                                          Handle<Cell>::null(),
-                                          function, Handle<String>::cast(name),
-                                          Code::FAST);
-    // A null handle means bail out to the regular compiler code below.
-    if (!code.is_null()) return code;
-  }
-
-  Label miss;
-  HandlerFrontendHeader(object, holder, name, check, &miss);
-  PatchGlobalProxy(object);
-  CompileHandlerBackend(function);
-  HandlerFrontendFooter(&miss);
-
-  // Return the generated code.
-  return GetCode(function);
-}
-
-
 Handle<Code> CallStubCompiler::CompileCallInterceptor(Handle<JSObject> object,
                                                       Handle<JSObject> holder,
                                                       Handle<Name> name) {
   Label miss;
   Register name_reg = x2;
 
   GenerateNameCheck(name, &miss);
 
   const int argc = arguments().immediate();
   LookupResult lookup(isolate());
   LookupPostInterceptor(holder, name, &lookup);
 
   // Get the receiver from the stack.
   Register receiver = x5;
   __ Peek(receiver, argc * kPointerSize);
 
-  CallInterceptorCompiler compiler(this, arguments(), name_reg, extra_state_);
+  CallInterceptorCompiler compiler(this, arguments(), name_reg, extra_state());
   compiler.Compile(
       masm(), object, holder, name, &lookup, receiver, x3, x4, x0, &miss);
 
   // Move returned value, the function to call, to x1 (this is required by
   // GenerateCallFunction).
   Register function = x1;
   __ Mov(function, x0);
 
   // Restore receiver.
   __ Peek(receiver, argc * kPointerSize);
 
-  GenerateCallFunction(
-      masm(), object, arguments(), &miss, extra_state_, function, receiver, x3);
+  GenerateJumpFunction(object, x1, &miss);
 
-  // Handle call cache miss.
-  __ Bind(&miss);
-  GenerateMissBranch();
+  HandlerFrontendFooter(&miss);
 
   // Return the generated code.
   return GetCode(Code::FAST, name);
 }
 
 
 Handle<Code> CallStubCompiler::CompileCallGlobal(
     Handle<JSObject> object,
     Handle<GlobalObject> holder,
     Handle<PropertyCell> cell,
     Handle<JSFunction> function,
     Handle<Name> name) {
   if (HasCustomCallGenerator(function)) {
     Handle<Code> code = CompileCustomCall(
         object, holder, cell, function, Handle<String>::cast(name),
         Code::NORMAL);
     // A null handle means bail out to the regular compiler code below.
     if (!code.is_null()) return code;
   }
 
   Label miss;
   HandlerFrontendHeader(object, holder, name, RECEIVER_MAP_CHECK, &miss);
+  // Potentially loads a closure that matches the shared function info of the
+  // function, rather than function.
   GenerateLoadFunctionFromCell(cell, function, &miss);
   // After these two calls the receiver is left in x0 and the function in x1.
   Register function_reg = x1;
 
-  PatchGlobalProxy(object);
-
-  // Set up the context.
-  __ Ldr(cp, FieldMemOperand(function_reg, JSFunction::kContextOffset));
-
-  // Jump to the cached code (tail call).
   Counters* counters = isolate()->counters();
   __ IncrementCounter(counters->call_global_inline(), 1, x3, x4);
-  ParameterCount expected(function->shared()->formal_parameter_count());
-  CallKind call_kind = CallICBase::Contextual::decode(extra_state_)
-      ? CALL_AS_FUNCTION
-      : CALL_AS_METHOD;
-  // We call indirectly through the code field in the function to
-  // allow recompilation to take effect without changing any of the
-  // call sites.
-  __ Ldr(x3, FieldMemOperand(function_reg, JSFunction::kCodeEntryOffset));
-  __ InvokeCode(
-      x3, expected, arguments(), JUMP_FUNCTION, NullCallWrapper(), call_kind);
-
+  GenerateJumpFunction(object, function_reg, function);
   HandlerFrontendFooter(&miss);
 
   // Return the generated code.
   return GetCode(Code::NORMAL, name);
 }
 
 
 Handle<Code> StoreStubCompiler::CompileStoreCallback(
     Handle<JSObject> object,
     Handle<JSObject> holder,
@@ skipping 361 matching lines @@
 
   // Miss case, call the runtime.
   __ Bind(&miss);
   TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_A64