Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 136643007: Revert of Reduce spam from CQ. (Closed)

Created:
6 years, 10 months ago by Sergey Berezin
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Revert of Reduce spam from CQ. (https://codereview.chromium.org/130983010/) Reason for revert: This did not fix the noise from the CQ. Reverting this and the previous patches. Original issue's description: > Reduce spam from CQ. > > My previous change https://codereview.chromium.org/138173005/ made CQ > post a message when the commit box was unchecked. It shouldn't have > posted it when CQ committed a change, but for some obscure reason it > did. Sometimes twice... > > This patch unifies the way an issue is removed from the queue, and in > particular, should eliminate most of the unwanted messages. Some CQ > messages about unchecked CQ box will still be posted when CQ drops it, > and it is expected to be rare. > > BUG=339116 > R=phajdan.jr@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=248553 TBR=phajdan.jr@chromium.org,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=339116 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=248623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -33 lines) Patch
M pending_manager.py View 1 chunk +9 lines, -2 lines 0 comments Download
M tests/pending_manager_test.py View 14 chunks +12 lines, -28 lines 0 comments Download
M tests/project_test.py View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Sergey Berezin
Created Revert of Reduce spam from CQ.
6 years, 10 months ago (2014-02-04 00:04:20 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 00:04:28 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-04 00:04:28 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:04:31 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:04:32 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:04:37 UTC) #6
Paweł Hajdan Jr.
LGTM stamp
6 years, 10 months ago (2014-02-04 00:08:17 UTC) #7
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 10 months ago (2014-02-04 00:09:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyberezin@chromium.org/136643007/1
6 years, 10 months ago (2014-02-04 00:09:19 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:09:52 UTC) #10
commit-bot: I haz the power
Change committed as 248623
6 years, 10 months ago (2014-02-04 00:09:52 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:09:53 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:10:00 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:10:01 UTC) #14
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698