Fix incorrect window show state after session restore.

Fix incorrect window show state after session restore.

If a user quits Chrome with two windows, both docked, on restore Chrome
will notice that neither window is fully visible and select the first
window in its restoration list to make visible. However, the profile
also has a notion of an active window, which session restore auto-
matically makes fully visible. The result is that depending on the order
in which the windows were placed in the dock, both windows can end up
restored fully visible instead of only one of them (which ideally should
be the last active window).

This change causes session restore to restore the last active window to
fully visible if all windows are hidden and the last active window
appears in the window restoration list.

BUG=536201
Committed: https://crrev.com/82b329e8cdbac775a5257989fd335d3e4641d713
Cr-Commit-Position: refs/heads/master@{#351164}

[shrike, 2015-09-25 22:17:29]

shrike@chromium.org changed reviewers:
+ sky@chromium.org

[shrike, 2015-09-25 22:19:03]

PTAL

[sky, 2015-09-28 14:54:05]

https://codereview.chromium.org/1366313003/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore.cc (right):

https://codereview.chromium.org/1366313003/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/session_restore.cc:393: (*i)->window_id.id() ==
active_window_id)
How is that the active window is in a minimized state?

[shrike, 2015-09-28 17:53:41]

https://codereview.chromium.org/1366313003/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore.cc (right):

https://codereview.chromium.org/1366313003/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/session_restore.cc:393: (*i)->window_id.id() ==
active_window_id)
On 2015/09/28 14:54:05, sky wrote:
> How is that the active window is in a minimized state?

As browser windows become active, SessionService::OnBrowserSetLastActive() gets
called from BrowserList::SetLastActive(). However if you minimize the last
visible browser window, SessionService::OnBrowserSetLastActive() does not get
called, so session restore is stuck remembering the last active browser window.

To clear out the last active browser window
SessionService::OnBrowserSetLastActive() would have to be called with either a
dummy browser window object or a nullptr. It looks like a nullptr can't be
passed in because SessionService::OnBrowserSet() immediately calls
SessionService::ShouldTrackBrowser() and it looks like that method would crash
if it received a nullptr.

[sky, 2015-09-28 19:04:02]

LGTM

https://codereview.chromium.org/1366313003/diff/20001/chrome/browser/sessions...
File chrome/browser/sessions/session_restore.cc (right):

https://codereview.chromium.org/1366313003/diff/20001/chrome/browser/sessions...
chrome/browser/sessions/session_restore.cc:393: (*i)->window_id.id() ==
active_window_id)
On 2015/09/28 17:53:41, shrike wrote:
> On 2015/09/28 14:54:05, sky wrote:
> > How is that the active window is in a minimized state?
> 
> As browser windows become active, SessionService::OnBrowserSetLastActive()
gets
> called from BrowserList::SetLastActive(). However if you minimize the last
> visible browser window, SessionService::OnBrowserSetLastActive() does not get
> called, so session restore is stuck remembering the last active browser
window.
> 
> To clear out the last active browser window
> SessionService::OnBrowserSetLastActive() would have to be called with either a
> dummy browser window object or a nullptr. It looks like a nullptr can't be
> passed in because SessionService::OnBrowserSet() immediately calls
> SessionService::ShouldTrackBrowser() and it looks like that method would crash
> if it received a nullptr.

Ok, makes sense.

[shrike, 2015-09-28 20:34:43]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2015-09-28 20:39:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366313003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366313003/20001

[commit-bot: I haz the power, 2015-09-28 21:23:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-28 21:29:27]

Patchset 2 (id:??) landed as
https://crrev.com/82b329e8cdbac775a5257989fd335d3e4641d713
Cr-Commit-Position: refs/heads/master@{#351164}