Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: chrome/browser/ui/libgtk2ui/BUILD.gn

Issue 1366253004: Roll buildtools f7310ee617..8d89c1b15f (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/libgtk2ui/BUILD.gn
diff --git a/chrome/browser/ui/libgtk2ui/BUILD.gn b/chrome/browser/ui/libgtk2ui/BUILD.gn
index 2db746b5d968b685a17c364311d4b138b7763f1e..9a92cba3c731c61f8dab2088a22f0778760767d3 100644
--- a/chrome/browser/ui/libgtk2ui/BUILD.gn
+++ b/chrome/browser/ui/libgtk2ui/BUILD.gn
@@ -7,6 +7,22 @@ assert(is_linux, "This file should only be referenced on Linux")
import("//build/config/features.gni")
import("//build/config/ui.gni")
+# gn orders flags on a target before flags from configs. The default config
+# adds -Wall, and these flags have to be after -Wall -- so they need to come
+# from a config and can't be on the target directly.
+config("libgtk2ui_warnings") {
+ if (is_clang) {
+ cflags = [
+ # G_DEFINE_TYPE automatically generates a *get_instance_private inline
+ # function after glib 2.37. That's unused. Prevent to complain about it.
+ "-Wno-unused-function",
+
+ # G_STATIC_ASSERT uses a typedef as a static_assert.
+ "-Wno-unused-local-typedef",
+ ]
+ }
+}
+
component("libgtk2ui") {
sources = [
"app_indicator_icon.cc",
@@ -74,21 +90,6 @@ component("libgtk2ui") {
# See crbug.com/462689 for details.
all_dependent_configs = [ "//third_party/harfbuzz-ng:pangoft2_link_hack" ]
- # gn orders flags on a target before flags from configs. The default config
- # adds -Wall, and these flags have to be after -Wall -- so they need to come
- # from a config and can't be on the target directly.
- config("libgtk2ui_warnings") {
- if (is_clang) {
- cflags = [
- # G_DEFINE_TYPE automatically generates a *get_instance_private inline
- # function after glib 2.37. That's unused. Prevent to complain about it.
- "-Wno-unused-function",
-
- # G_STATIC_ASSERT uses a typedef as a static_assert.
- "-Wno-unused-local-typedef",
- ]
- }
- }
configs += [
":libgtk2ui_warnings",
"//build/config/linux:x11",
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698