Roll buildtools f7310ee617..8d89c1b15f

Roll buildtools f7310ee617..8d89c1b15f

  In order to roll GN 5142dc7611..97a89f6b3f (r348229:r350897) and pick up
  the following changes:

  3b6a2f1 Make some global pointers const void* const.
  40fc484 [GN]: Add asmflags
  23dca52 [GN]: Remove dead code GetExtensionForOutputType
  1f9152a Build GN with c++11.
  b52c507 Add ninja console pool support to GN
  4f28b8c [GN]: Fix bug where cflag vars were not being written on non-PCH builds
  6f3d71b Attempt to fix race in GN auto-roller again.
  aedcc8a Fix GN docs for 'gn help deps' and update reference.md.
  e6d30d0 [GN]: Fix bad doc links.
  a6108a3 Fix race and error case in GN auto-roller script.
  bfd2dea Improve GN duplicate name error.
  1ae777a [GN]: Precompiled header support for GCC.
  62ce4f0 Hook up "--threads" to gn help.
  bd14442 Allow GN configs to have sub-configs.
  c5166a2 Fix some typos in gn's documentation for "copy".
  56807c6 gn help switches doc fixup
  3cb0032 Replace instances of datadeps --> data_deps.
  dfba3a3 gn-mode: Clear indent-tabs-mode
  4cab0f1 Move sanitizer and symbol flags out of BUILDCONFIG
  91e3ca5 Fix some typos in GN documentation.
  314880a Fixes for 32-bit official GN build.
  e6168f0 Escape "--" in markdown rendering for GN reference docs.
  84ffc7e Fix GN auto-roller to handle results from buildbucket-initiated jobs.

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Committed: https://crrev.com/75c892a2a01fccf4cb171b2b0815f018aa58a08d
Cr-Commit-Position: refs/heads/master@{#350985}

[Bons, 2015-09-25 20:26:26]

The CQ bit was checked by andybons@chromium.org

[commit-bot: I haz the power, 2015-09-25 20:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366253004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366253004/1

[Dirk Pranke, 2015-09-25 20:30:28]

Updated the subject to say 'roll buildtools' instead of 'roll deps'; the latter
is confusing, and something I keep forgetting to fix in the roll script.

lgtm otherwise.

[commit-bot: I haz the power, 2015-09-25 20:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 20:49:59]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bons, 2015-09-25 21:07:41]

The CQ bit was checked by andybons@chromium.org

[commit-bot: I haz the power, 2015-09-25 21:09:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366253004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366253004/1

[commit-bot: I haz the power, 2015-09-25 21:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 21:44:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bons, 2015-09-25 23:53:20]

The CQ bit was checked by andybons@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-25 23:53:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366253004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366253004/40001

[Dirk Pranke, 2015-09-26 01:07:01]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2015-09-26 01:07:01]

No LGTM .

Let's wait on landing this until Brett can take a look at what's going on
crbug.com/536290 (the fact that the config wasn't applied until we unnested it,
and we didn't get an error either).

I'd also like Brett to get a chance to look at crbug.com/536289 (an unrelated
but potentially serious GN bug related to handling isolates).

It may be that we should land the latest GN binary because the bugs are not
introduced in this roll, but I'd like to see what he thinks first.

[Bons, 2015-09-26 01:08:47]

On 2015/09/26 01:07:01, Dirk Pranke wrote:
> No LGTM .
> 
> Let's wait on landing this until Brett can take a look at what's going on
> crbug.com/536290 (the fact that the config wasn't applied until we unnested
it,
> and we didn't get an error either).
> 
> I'd also like Brett to get a chance to look at crbug.com/536289 (an unrelated
> but potentially serious GN bug related to handling isolates).
> 
> It may be that we should land the latest GN binary because the bugs are not
> introduced in this roll, but I'd like to see what he thinks first.

OK. Will take no action on anything. If you feel like landing just CQ it.

[commit-bot: I haz the power, 2015-09-26 01:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 01:16:14]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-09-26 04:41:52]

I checked for other nested configs inside template invocations and didn't see
any. I updated the bug with what's happening.

I think it will be easier to get this hairball of a roll in and then add this
case to the nested config checker in a second pass, so I'm pressing CQ.

[brettw, 2015-09-26 04:41:56]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-09-26 04:42:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1366253004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1366253004/40001

[commit-bot: I haz the power, 2015-09-26 04:47:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-26 04:47:47]

Patchset 3 (id:??) landed as
https://crrev.com/75c892a2a01fccf4cb171b2b0815f018aa58a08d
Cr-Commit-Position: refs/heads/master@{#350985}