Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Unified Diff: chrome/browser/ui/browser.cc

Issue 1366203003: Fix tab discarding reload count metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ThreadChecker ==> DCHECK_CURRENTLY_ON Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/tabs/tab_discard_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 3fc985515f324c981693dfc65dda81a182c1a93a..525be6e772040ab80b7df91e5be49ba101e825ed 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1054,13 +1054,8 @@ void Browser::ActiveTabChanged(WebContents* old_contents,
exclusive_access_manager_->OnTabDetachedFromView(old_contents);
// Discarded tabs always get reloaded.
- if (TabDiscardState::IsDiscarded(new_contents)) {
- LOG(WARNING) << "Reloading discarded tab at " << index;
- static int reload_count = 0;
- UMA_HISTOGRAM_CUSTOM_COUNTS(
- "Tabs.Discard.ReloadCount", ++reload_count, 1, 1000, 50);
+ if (TabDiscardState::IsDiscarded(new_contents))
chrome::Reload(this, CURRENT_TAB);
- }
// If we have any update pending, do it now.
if (chrome_updater_factory_.HasWeakPtrs() && old_contents)
« no previous file with comments | « no previous file | chrome/browser/ui/tabs/tab_discard_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698