Fix tab discarding reload count metric.

chrome/browser/ui/tabs/tab_discard_state.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tabs/tab_discard_state.h"
 
+#include "base/metrics/histogram.h"
 #include "content/public/browser/web_contents.h"
 
 using content::WebContents;
 
 namespace {
 
 const char kDiscardStateKey[] = "TabDiscardState";
 
 }  // namespace
 
@@ skipping 18 matching lines @@
 }
 
 // static
 bool TabDiscardState::IsDiscarded(WebContents* web_contents) {
   TabDiscardState* discard_state = TabDiscardState::Get(web_contents);
   return discard_state->is_discarded_;
 }
 
 // static
 void TabDiscardState::SetDiscardState(WebContents* web_contents, bool state) {
   TabDiscardState* discard_state = TabDiscardState::Get(web_contents);

[chrisha, 2015/09/25 17:11:52]

Does this object only get called from a single thread?

Maybe add a thread-checker to make sure? Otherwise there's still a race
condition.

[Georges Khalil, 2015/09/25 18:36:25]

Should all be on the UI thread.

Added thread checker just in case.

+
+  if (discard_state->is_discarded_ && !state) {
+    static int reload_count = 0;
+    UMA_HISTOGRAM_CUSTOM_COUNTS("Tabs.Discard.ReloadCount", ++reload_count, 1,
+                                1000, 50);
+  }
+
   discard_state->is_discarded_ = state;
 }
 
 // static
 int TabDiscardState::DiscardCount(WebContents* web_contents) {
   TabDiscardState* discard_state = TabDiscardState::Get(web_contents);
   return discard_state->discard_count_;
 }
 
 // static
 void TabDiscardState::IncrementDiscardCount(WebContents* web_contents) {
   TabDiscardState* discard_state = TabDiscardState::Get(web_contents);
   discard_state->discard_count_++;
 }
 
 // static
 void TabDiscardState::CopyState(content::WebContents* old_contents,
                                 content::WebContents* new_contents) {
   TabDiscardState* old_state = Get(old_contents);
   TabDiscardState* new_State = Get(new_contents);
   *new_State = *old_state;
 }