Chromium Code Reviews| Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp |
| diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp |
| index 3f5dd7c48d0177125c6eb69e26ee4419b34ee1dc..5486a87bd3e0ecca9f359c217f988cefe25a285e 100644 |
| --- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp |
| +++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp |
| @@ -16,6 +16,7 @@ namespace { |
| using namespace WTF; |
| const char kPartitionAllocDumpName[] = "partition_alloc"; |
| +const char kPartitionAllocPoolName[] = "partition_alloc/allocated_objects"; |
| const char kPartitionsDumpName[] = "partitions"; |
|
haraken
2015/09/29 16:20:17
How about just defining these constant strings in
|
| String getPartitionDumpName(const char* partitionName) |
| @@ -100,8 +101,7 @@ bool PartitionAllocMemoryDumpProvider::onMemoryDump(WebMemoryDumpLevelOfDetail l |
| // This method calls memoryStats.partitionsDumpBucketStats with memory statistics. |
| WTF::Partitions::dumpMemoryStats(levelOfDetail == WebMemoryDumpLevelOfDetail::Light, &partitionStatsDumper); |
| - WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump( |
| - String::format("%s/allocated_objects", kPartitionAllocDumpName)); |
| + WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(kPartitionAllocPoolName); |
| allocatedObjectsDump->AddScalar("size", "bytes", partitionStatsDumper.totalActiveBytes()); |
| memoryDump->AddOwnershipEdge(allocatedObjectsDump->guid(), partitionsDump->guid()); |
| @@ -110,6 +110,7 @@ bool PartitionAllocMemoryDumpProvider::onMemoryDump(WebMemoryDumpLevelOfDetail l |
| PartitionAllocMemoryDumpProvider::PartitionAllocMemoryDumpProvider() |
| { |
| + Partitions::setAllocatorPoolNameForTracing(kPartitionAllocPoolName); |
| } |
| PartitionAllocMemoryDumpProvider::~PartitionAllocMemoryDumpProvider() |