Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

Issue 1366203002: Add dump name for tracing in PartitionAlloc for sub-allocations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web_cache
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/Partitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
index 3f5dd7c48d0177125c6eb69e26ee4419b34ee1dc..5486a87bd3e0ecca9f359c217f988cefe25a285e 100644
--- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
+++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
@@ -16,6 +16,7 @@ namespace {
using namespace WTF;
const char kPartitionAllocDumpName[] = "partition_alloc";
+const char kPartitionAllocPoolName[] = "partition_alloc/allocated_objects";
const char kPartitionsDumpName[] = "partitions";
haraken 2015/09/29 16:20:17 How about just defining these constant strings in
String getPartitionDumpName(const char* partitionName)
@@ -100,8 +101,7 @@ bool PartitionAllocMemoryDumpProvider::onMemoryDump(WebMemoryDumpLevelOfDetail l
// This method calls memoryStats.partitionsDumpBucketStats with memory statistics.
WTF::Partitions::dumpMemoryStats(levelOfDetail == WebMemoryDumpLevelOfDetail::Light, &partitionStatsDumper);
- WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(
- String::format("%s/allocated_objects", kPartitionAllocDumpName));
+ WebMemoryAllocatorDump* allocatedObjectsDump = memoryDump->createMemoryAllocatorDump(kPartitionAllocPoolName);
allocatedObjectsDump->AddScalar("size", "bytes", partitionStatsDumper.totalActiveBytes());
memoryDump->AddOwnershipEdge(allocatedObjectsDump->guid(), partitionsDump->guid());
@@ -110,6 +110,7 @@ bool PartitionAllocMemoryDumpProvider::onMemoryDump(WebMemoryDumpLevelOfDetail l
PartitionAllocMemoryDumpProvider::PartitionAllocMemoryDumpProvider()
{
+ Partitions::setAllocatorPoolNameForTracing(kPartitionAllocPoolName);
}
PartitionAllocMemoryDumpProvider::~PartitionAllocMemoryDumpProvider()
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/Partitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698