Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: src/heap/heap.h

Issue 1366183003: [heap] No leakage of mark-compact.h outside of heap. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index 8fdc6702b1d690d72614f4ce914bd91291549660..203afa1aa71f3281b750fe24534ab18e34cb0870 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -8,12 +8,14 @@
#include <cmath>
#include <map>
+// Clients of this interface shouldn't depend on lots of heap internals.
+// Do not include anything from src/heap here!
#include "src/allocation.h"
#include "src/assert-scope.h"
#include "src/atomic-utils.h"
#include "src/globals.h"
+// TODO(mstarzinger): Three more includes to kill!
#include "src/heap/incremental-marking.h"
-#include "src/heap/mark-compact.h"
#include "src/heap/spaces.h"
#include "src/heap/store-buffer.h"
#include "src/list.h"
@@ -1096,7 +1098,7 @@ class Heap {
inline Isolate* isolate();
MarkCompactCollector* mark_compact_collector() {
- return &mark_compact_collector_;
+ return mark_compact_collector_;
}
// ===========================================================================
@@ -2255,7 +2257,7 @@ class Heap {
Scavenger* scavenge_collector_;
- MarkCompactCollector mark_compact_collector_;
+ MarkCompactCollector* mark_compact_collector_;
StoreBuffer store_buffer_;
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698