Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1366183003: [heap] No leakage of mark-compact.h outside of heap. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] No leakage of mark-compact.h outside of heap. R=hpayer@chromium.org Committed: https://crrev.com/4f55b83012247148e7040771bdcfccaea352201a Cr-Commit-Position: refs/heads/master@{#30961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M src/heap/heap.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 11 chunks +22 lines, -15 lines 0 comments Download
M src/heap/incremental-marking.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-25 14:52:15 UTC) #1
Hannes Payer (out of office)
yiha, lgtm
5 years, 2 months ago (2015-09-28 07:34:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366183003/1
5 years, 2 months ago (2015-09-28 07:41:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 08:04:23 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 08:04:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f55b83012247148e7040771bdcfccaea352201a
Cr-Commit-Position: refs/heads/master@{#30961}

Powered by Google App Engine
This is Rietveld 408576698