Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1366163002: Enable subsequence caching (Closed)

Created:
5 years, 3 months ago by Xianzhu
Modified:
5 years, 2 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable subsequence caching BUG=410097 Committed: https://crrev.com/80bdce2c101c3c6a8a2383b8d7035df7bdd5c0c4 Cr-Commit-Position: refs/heads/master@{#350965}

Patch Set 1 #

Patch Set 2 : Fix webkit_unit_tests (test expectations not updated to make revert easier) #

Patch Set 3 : Update virtual/threaded/inspector/tracing/timeline-paint-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
A + third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/timeline-paint-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/DisplayItemListPaintTest.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Xianzhu
Let's try to enable it on M47 and see if there are other regressions.
5 years, 3 months ago (2015-09-25 04:06:31 UTC) #2
chrishtr
lgtm
5 years, 2 months ago (2015-09-25 16:03:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366163002/1
5 years, 2 months ago (2015-09-25 16:04:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/118594)
5 years, 2 months ago (2015-09-25 16:51:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366163002/20001
5 years, 2 months ago (2015-09-25 17:06:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/112449)
5 years, 2 months ago (2015-09-25 18:21:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366163002/40001
5 years, 2 months ago (2015-09-25 22:06:40 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-26 01:13:12 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/80bdce2c101c3c6a8a2383b8d7035df7bdd5c0c4 Cr-Commit-Position: refs/heads/master@{#350965}
5 years, 2 months ago (2015-09-26 01:14:35 UTC) #17
Xianzhu
5 years, 2 months ago (2015-09-28 21:41:43 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1377643002/ by wangxianzhu@chromium.org.

The reason for reverting is: There are still some regressions.

BUG=410097,536764,536674,533717.

Powered by Google App Engine
This is Rietveld 408576698