Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1366153002: Use host instead of current OS for NaCl toolchain location (Closed)

Created:
5 years, 2 months ago by Petr Hosek
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use host instead of current OS for NaCl toolchain location We should be using the host OS for determining the toolchain location as this is the OS toolchain is going to be running on. BUG=462791 Committed: https://crrev.com/f68cf5be7c8cd51e51a5c02777053518b2e529e9 Cr-Commit-Position: refs/heads/master@{#350734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/nacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Petr Hosek
5 years, 2 months ago (2015-09-25 00:21:35 UTC) #2
Dirk Pranke
lgtm
5 years, 2 months ago (2015-09-25 00:21:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366153002/1
5 years, 2 months ago (2015-09-25 00:24:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 01:19:41 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 01:20:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f68cf5be7c8cd51e51a5c02777053518b2e529e9
Cr-Commit-Position: refs/heads/master@{#350734}

Powered by Google App Engine
This is Rietveld 408576698