Issue 136613003: Demystified floating point ABI function names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136613003: Demystified floating point ABI function names. (Closed)

Created:
6 years, 11 months ago by Sven Panne

Modified:
6 years, 11 months ago

Reviewers:
ulan

CC:
v8-dev, Rodolph Perfetta, Paul Lind

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Demystified floating point ABI function names. This unifies the names used for floating point ABI abstraction across ARM and MIPS and makes them more comprehensible. Note that in the underlying implementation, ARM doesn't care about the argument/result distinction, while MIPS does, but we want to abstract from that, too. Nuked an unused related function on the way. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18567

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -80 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	3 chunks	+20 lines, -20 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mips/codegen-mips.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	3 chunks	+18 lines, -30 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

6 years, 11 months ago (2014-01-13 13:25:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18567 (presubmit successful).

Expand Messages | Collapse Messages