Stop generating dumps in the referrer check, but log in all developer builds

Stop generating dumps in the referrer check, but log in all developer builds

BUG=none
R=mef@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244518

[jochen (gone - plz use gerrit), 2014-01-13 12:44:03]

plz review

[mef, 2014-01-13 14:40:28]

On 2014/01/13 12:44:03, jochen wrote:
> plz review

Could you share the motivation? 
It would seem that without dump we will not have the explanation (like call
stack or something) of the error condition.

[jochen (gone - plz use gerrit), 2014-01-13 14:42:56]

On 2014/01/13 14:40:28, mef wrote:
> On 2014/01/13 12:44:03, jochen wrote:
> > plz review
> 
> Could you share the motivation? 
> It would seem that without dump we will not have the explanation (like call
> stack or something) of the error condition.

based on the reports I got, I fixed all errors.

I'm still getting reports, but I have no idea what's going on. However, we have
enough reports for now, and the TPMs are getting nervous about the noise.

I'm keeping the LOG(FATAL) so if a developers stumbles on this, I get a bug
report with repro steps (hopefully)

[mef, 2014-01-13 15:04:35]

On 2014/01/13 14:42:56, jochen wrote:
> On 2014/01/13 14:40:28, mef wrote:
> > On 2014/01/13 12:44:03, jochen wrote:
> > > plz review
> > 
> > Could you share the motivation? 
> > It would seem that without dump we will not have the explanation (like call
> > stack or something) of the error condition.
> 
> based on the reports I got, I fixed all errors.
> 
> I'm still getting reports, but I have no idea what's going on. However, we
have
> enough reports for now, and the TPMs are getting nervous about the noise.
> 
> I'm keeping the LOG(FATAL) so if a developers stumbles on this, I get a bug
> report with repro steps (hopefully)

Ah, sounds good. If you still get reports, then would it make sense to actually
clear referrer in official build?

[jochen (gone - plz use gerrit), 2014-01-13 15:09:34]

On 2014/01/13 15:04:35, mef wrote:
> On 2014/01/13 14:42:56, jochen wrote:
> > On 2014/01/13 14:40:28, mef wrote:
> > > On 2014/01/13 12:44:03, jochen wrote:
> > > > plz review
> > > 
> > > Could you share the motivation? 
> > > It would seem that without dump we will not have the explanation (like
call
> > > stack or something) of the error condition.
> > 
> > based on the reports I got, I fixed all errors.
> > 
> > I'm still getting reports, but I have no idea what's going on. However, we
> have
> > enough reports for now, and the TPMs are getting nervous about the noise.
> > 
> > I'm keeping the LOG(FATAL) so if a developers stumbles on this, I get a bug
> > report with repro steps (hopefully)
> 
> Ah, sounds good. If you still get reports, then would it make sense to
actually
> clear referrer in official build?

yes, that's still being done

[mef, 2014-01-13 15:18:40]

On 2014/01/13 15:09:34, jochen wrote:
> On 2014/01/13 15:04:35, mef wrote:
> > On 2014/01/13 14:42:56, jochen wrote:
> > > On 2014/01/13 14:40:28, mef wrote:
> > > > On 2014/01/13 12:44:03, jochen wrote:
> > > > > plz review
> > > > 
> > > > Could you share the motivation? 
> > > > It would seem that without dump we will not have the explanation (like
> call
> > > > stack or something) of the error condition.
> > > 
> > > based on the reports I got, I fixed all errors.
> > > 
> > > I'm still getting reports, but I have no idea what's going on. However, we
> > have
> > > enough reports for now, and the TPMs are getting nervous about the noise.
> > > 
> > > I'm keeping the LOG(FATAL) so if a developers stumbles on this, I get a
bug
> > > report with repro steps (hopefully)
> > 
> > Ah, sounds good. If you still get reports, then would it make sense to
> actually
> > clear referrer in official build?
> 
> yes, that's still being done

Oh, I've missed that, sorry. LGTM

[commit-bot: I haz the power, 2014-01-13 15:21:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/136613002/1

[commit-bot: I haz the power, 2014-01-13 16:57:37]

Change committed as 244518