Improve HostOptions unit tests

remoting/webapp/base/js/host_options_unittest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 QUnit.module('HostOptions', {
   beforeEach: function() {
     sinon.stub(remoting, 'platformIsChromeOS');
   },
@@ skipping 38 matching lines @@
     var options = new remoting.HostOptions('host-id');
     return options.load().then(
         function() {
           assertDefaults(assert, options, true);
         });
 });
 
 QUnit.test('Saving and loading a host preserves the saved values',
   function(assert) {
     var options = new remoting.HostOptions('host-id');
+    var optionsNew = new remoting.HostOptions('host-id');

[Jamie, 2015/09/26 00:40:41]

Loading into the same object as we saved would trivially pass if load() was a
no-op, which is not what we want.

[kelvinp, 2015/09/28 18:36:40]

Nit: optionsLoaded may be a more descriptive name. 

[Jamie, 2015/09/28 21:33:48]

Done.

     options.setShrinkToFit(false);
     options.setResizeToClient(false);
     options.setDesktopScale(2);
     options.setRemapKeys({2: 1, 1: 2});
     options.setPairingInfo({
       clientId: 'client-id',
       sharedSecret: 'shared-secret'
     });
     var optionsCopy = base.deepCopy(options);
 
     return options.save().then(function() {
-      return options.load();
+      return optionsNew.load();
     }).then(function() {
-      assert.deepEqual(optionsCopy, base.deepCopy(options));
+      assert.deepEqual(optionsCopy, base.deepCopy(optionsNew));
     });
 });
 
 QUnit.test('Saving a host ignores unset values',
   function(assert) {
     var options = new remoting.HostOptions('host-id');
+    options.setShrinkToFit(false);
     var optionsCopy = base.deepCopy(options);
+    var optionsEmpty = new remoting.HostOptions('host-id');

[Jamie, 2015/09/26 00:40:41]

This test wasn't really testing anything previously. Now we assert that
non-default values are not reset when loading an object that didn't have an
override set when it was saved.

 
-    return options.save().then(function() {
+    return optionsEmpty.save().then(function() {
       return options.load();
     }).then(function() {
       assert.deepEqual(optionsCopy, base.deepCopy(options));
     });
 });
 
 QUnit.test('Old-style (string-formatted) key remappings are parsed correctly',
   function(assert) {
     var options1 = new remoting.HostOptions('host-id');
     options1.setRemapKeys({2: 1, 1: 2});
     var savedHostOptions = {
       'host-id': {
         'remapKeys': '2>1,1>2'
       }
     };
     var savedAllOptions = {
       'remoting-host-options': JSON.stringify(savedHostOptions)
     };
     chrome.storage.local.set(savedAllOptions);  // Mock storage is synchronous
     var options2 = new remoting.HostOptions('host-id');
     return options2.load().then(
         function() {
           assert.deepEqual(options1, options2);
         });
 });
+
+QUnit.test('New options are loaded and saved without updating the code',
+  function(assert) {
+    var options = new remoting.HostOptions('host-id');
+    var optionsNew = new remoting.HostOptions('host-id');
+    options['undefined-option'] = 42;
+    var optionsCopy = base.deepCopy(options);
+
+    return options.save().then(function() {
+      return optionsNew.load();
+    }).then(function() {
+      assert.deepEqual(optionsCopy, base.deepCopy(optionsNew));

[kelvinp, 2015/09/28 18:36:40]

Nit: maybe good to assert options['undefined-options] == 42 to more explicitly
call out what the expected behavior is.

[Jamie, 2015/09/28 21:33:48]

Done.

+    });
+});