Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 1366063002: [es6] Remove left-overs from Function.prototype.toMethod. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Remove left-overs from Function.prototype.toMethod. The actual Function.prototype.toMethod was removed some time already, but there were some stuff (esp. %ToMethod) left in the tree, including tests for %ToMethod. This code (and esp. the tests) cause trouble in the process of moving bound functions away from JSFunction; so since the code is unused anyway, we can as well remove it. The original removal of Function.prototype.toMethod was in February 2015 in 68e489758607bb7373409b49a0a7883407a322b3. R=jarin@chromium.org BUG=v8:3330 LOG=n Committed: https://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76 Cr-Commit-Position: refs/heads/master@{#30925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -236 lines) Patch
M src/objects.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D test/mjsunit/es6/toMethod.js View 1 chunk +0 lines, -106 lines 0 comments Download
M test/mjsunit/harmony/super.js View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Dead code must be dead!
5 years, 2 months ago (2015-09-25 03:42:43 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-09-25 04:02:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366063002/1
5 years, 2 months ago (2015-09-25 04:02:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 04:04:34 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 04:04:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff2c9eace4cd987de3efcfdddc92143ede5d2c76
Cr-Commit-Position: refs/heads/master@{#30925}

Powered by Google App Engine
This is Rietveld 408576698