Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1366053004: Material PDF: Improve layout of PDF viewer in very small windows (Closed)

Created:
5 years, 2 months ago by tsergeant
Modified:
5 years, 2 months ago
Reviewers:
raymes
CC:
arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material PDF: Improve layout of PDF viewer in very small windows Progressively hide elements to make sure that the viewer is still usable in very small windows and embeds BUG=535421 Committed: https://crrev.com/b9ecdc94bc359c7d16b9c5a93492fcb1e532ef7a Cr-Commit-Position: refs/heads/master@{#351484}

Patch Set 1 #

Patch Set 2 : Tweak behaviour #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M chrome/browser/resources/pdf/elements/viewer-pdf-toolbar/viewer-pdf-toolbar.css View 1 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.css View 1 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 2 chunks +9 lines, -1 line 2 comments Download

Messages

Total messages: 11 (4 generated)
tsergeant
As discussed: Changed the top toolbar to never hide, but the behaviour for short windows ...
5 years, 2 months ago (2015-09-28 06:50:00 UTC) #4
raymes
https://codereview.chromium.org/1366053004/diff/60001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1366053004/diff/60001/chrome/browser/resources/pdf/pdf.js#newcode153 chrome/browser/resources/pdf/pdf.js:153: var shortWindow = window.innerHeight < PDFViewer.TOOLBAR_WINDOW_MIN_HEIGHT; Perhaps we should ...
5 years, 2 months ago (2015-09-28 07:42:45 UTC) #5
tsergeant
https://codereview.chromium.org/1366053004/diff/60001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/1366053004/diff/60001/chrome/browser/resources/pdf/pdf.js#newcode153 chrome/browser/resources/pdf/pdf.js:153: var shortWindow = window.innerHeight < PDFViewer.TOOLBAR_WINDOW_MIN_HEIGHT; On 2015/09/28 at ...
5 years, 2 months ago (2015-09-30 01:26:49 UTC) #6
raymes
Ah that makes sense. lgtm
5 years, 2 months ago (2015-09-30 01:52:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366053004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366053004/60001
5 years, 2 months ago (2015-09-30 02:32:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-09-30 03:53:54 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 03:54:51 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b9ecdc94bc359c7d16b9c5a93492fcb1e532ef7a
Cr-Commit-Position: refs/heads/master@{#351484}

Powered by Google App Engine
This is Rietveld 408576698