Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/include/jsapi/fxjs_v8.h

Issue 1366053003: XFA: Pass IFXJS_Runtime via V8 contexts, not V8 isolates (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/include/javascript/JS_Define.h ('K') | « fpdfsdk/include/javascript/JS_Define.h ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/jsapi/fxjs_v8.h
diff --git a/fpdfsdk/include/jsapi/fxjs_v8.h b/fpdfsdk/include/jsapi/fxjs_v8.h
index a1e3e5979713e421d97a39cc4e2a8471aa6eefa0..0b51332dbcaa8a346bb3fa4d2dfbf9f8f95098f4 100644
--- a/fpdfsdk/include/jsapi/fxjs_v8.h
+++ b/fpdfsdk/include/jsapi/fxjs_v8.h
@@ -39,12 +39,10 @@ class FXJS_PerIsolateData {
static FXJS_PerIsolateData* Get(v8::Isolate* pIsolate);
CFX_PtrArray m_ObjectDefnArray;
- IFXJS_Runtime* m_pFXJSRuntime;
CFXJSE_RuntimeData* m_pFXJSERuntimeData;
protected:
- FXJS_PerIsolateData()
- : m_pFXJSRuntime(nullptr), m_pFXJSERuntimeData(nullptr) {}
+ FXJS_PerIsolateData() : m_pFXJSERuntimeData(nullptr) {}
};
extern const wchar_t kFXJSValueNameString[];
« fpdfsdk/include/javascript/JS_Define.h ('K') | « fpdfsdk/include/javascript/JS_Define.h ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698