Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136603003: Move settings link for ChromeVox to a better location (Closed)

Created:
6 years, 11 months ago by Zachary Kuznia
Modified:
6 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Move settings link for ChromeVox to a better location BUG=126823 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/resources/options/browser_options.html View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Zachary Kuznia
Please take a look
6 years, 11 months ago (2014-01-14 01:31:48 UTC) #1
xiyuan
lgtm
6 years, 11 months ago (2014-01-14 01:40:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/136603003/1
6 years, 11 months ago (2014-01-14 02:30:44 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=245897
6 years, 11 months ago (2014-01-14 07:21:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/136603003/1
6 years, 11 months ago (2014-01-14 20:24:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/136603003/1
6 years, 11 months ago (2014-01-14 23:24:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/136603003/1
6 years, 11 months ago (2014-01-15 02:52:57 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 03:02:09 UTC) #8
Message was sent while issue was closed. 
Change committed as 245082

Powered by Google App Engine
This is Rietveld 408576698