chrome/browser/download/notification/download_notification_manager.cc - Issue 1365963004: Don't compile download notification code on !CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_notification_manager.cc

Issue 1365963004: Don't compile download notification code on !CrOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: images and strings Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/theme/theme_resources.grd ('K') | « chrome/browser/download/notification/download_item_notification.cc ('k') | chrome/browser/download/save_page_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_notification_manager.cc

diff --git a/chrome/browser/download/notification/download_notification_manager.cc b/chrome/browser/download/notification/download_notification_manager.cc

index 64ad9a77ca4b344f016f03b7639ad723ab3e158f..41e75a893d584ca2ef3c5ef0598565a3333d8159 100644

--- a/chrome/browser/download/notification/download_notification_manager.cc

+++ b/chrome/browser/download/notification/download_notification_manager.cc

@@ -24,12 +24,7 @@

///////////////////////////////////////////////////////////////////////////////

bool DownloadNotificationManager::IsEnabled() {

-#if defined(OS_CHROMEOS)

bool enable_download_notification = true;

-#else

- bool enable_download_notification = false;

-#endif

std::string arg = base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(

switches::kEnableDownloadNotification);

if (!arg.empty()) {